Skip to content

Use database to keep track of session cleaning #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 5, 2023
Merged

Use database to keep track of session cleaning #167

merged 16 commits into from
Aug 5, 2023

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Aug 4, 2023 •
edited
Loading

Description

  • Use database to keep track of when ReactPy last performs a clean.
    • Previously done via a cache entry for performance. But realistically we should assume the user is either utilizing a performant DB, or doesn't care about performance to begin with.
  • Store web module file contents in cache, instead of the HTTP Response
  • Add a timeout to the web module cached files to allow old entries to be deleted.

Checklist:

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog has been updated with any significant changes, if necessary.
  • GitHub Issues which may be closed by this PR have been linked.

@Archmonger Archmonger changed the title Use-db-for-clean-tracking Use database to keep track of cleaning Aug 4, 2023
@Archmonger Archmonger force-pushed the use-db-for-clean-tracking branch from e5b667d to 0107b18 Compare August 4, 2023 07:08
@Archmonger Archmonger force-pushed the use-db-for-clean-tracking branch from 0107b18 to ce9d65e Compare August 4, 2023 07:31
@Archmonger Archmonger marked this pull request as ready for review August 4, 2023 10:14
@Archmonger Archmonger requested a review from a team as a code owner August 4, 2023 10:14
@Archmonger Archmonger changed the title Use database to keep track of cleaning Use database to keep track of session cleaning Aug 4, 2023
@Archmonger
Copy link
Contributor Author

Merging so I can create a v3.3.0 release. Will handle review comments in a follow up PR if needed.

@Archmonger Archmonger merged commit 9db202b into reactive-python:main Aug 5, 2023
@Archmonger Archmonger deleted the use-db-for-clean-tracking branch August 5, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Archmonger