Skip to content

Commit 97e9219

Browse files
committed
feat: use rc-util
1 parent 998d7d1 commit 97e9219

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
"create-react-class": "15.x",
8181
"prop-types": "15.x",
8282
"rc-hammerjs": "~0.6.0",
83+
"rc-util": "^4.0.4",
8384
"warning": "^3.0.0"
8485
}
8586
}

src/TabBarMixin.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import React, { cloneElement } from 'react';
22
import classnames from 'classnames';
33
import warning from 'warning';
4+
import pickAttrs from 'rc-util/lib/pickAttrs';
45

56
export default {
67
getDefaultProps() {
@@ -12,11 +13,9 @@ export default {
1213
this.props.onTabClick(key);
1314
},
1415
getTabs() {
15-
const props = this.props;
16-
const children = props.panels;
17-
const activeKey = props.activeKey;
16+
const { panels, activeKey, prefixCls } = this.props;
17+
const { children } = panels;
1818
const rst = [];
19-
const prefixCls = props.prefixCls;
2019

2120
React.Children.forEach(children, (child) => {
2221
if (!child) {
@@ -58,7 +57,6 @@ export default {
5857
getRootNode(contents) {
5958
const {
6059
prefixCls, onKeyDown, className, extraContent, style, tabBarPosition,
61-
pageSize, styles, inkBarAnimated, hammerOptions, onTabClick, panels, activeKey,
6260
...restProps,
6361
} = this.props;
6462
const cls = classnames(`${prefixCls}-bar`, {
@@ -89,7 +87,7 @@ export default {
8987
ref="root"
9088
onKeyDown={onKeyDown}
9189
style={style}
92-
{...restProps}
90+
{...pickAttrs(restProps)}
9391
>
9492
{children}
9593
</div>

src/TabPane.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import React from 'react';
22
import PropTypes from 'prop-types';
33
import createReactClass from 'create-react-class';
44
import classnames from 'classnames';
5+
import pickAttrs from 'rc-util/lib/pickAttrs';
56

67
const TabPane = createReactClass({
78
displayName: 'TabPane',
@@ -18,9 +19,8 @@ const TabPane = createReactClass({
1819
},
1920
render() {
2021
const {
21-
className, destroyInactiveTabPane, active, forceRender, rootPrefixCls, style,
22-
children, placeholder, tab,
23-
...restProps,
22+
className, destroyInactiveTabPane, active, forceRender,
23+
rootPrefixCls, style, children, placeholder, ...restProps,
2424
} = this.props;
2525
this._isActived = this._isActived || active;
2626
const prefixCls = `${rootPrefixCls}-tabpane`;
@@ -37,7 +37,7 @@ const TabPane = createReactClass({
3737
role="tabpanel"
3838
aria-hidden={active ? 'false' : 'true'}
3939
className={cls}
40-
{...restProps}
40+
{...pickAttrs(restProps)}
4141
>
4242
{isRender || forceRender ? children : placeholder}
4343
</div>

src/Tabs.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React from 'react';
22
import PropTypes from 'prop-types';
3+
import pickAttrs from 'rc-util/lib/pickAttrs';
34
import KeyCode from './KeyCode';
45
import TabPane from './TabPane';
56
import classnames from 'classnames';
@@ -117,7 +118,6 @@ export default class Tabs extends React.Component {
117118
tabBarPosition, className,
118119
renderTabContent,
119120
renderTabBar,
120-
defaultActiveKey,
121121
destroyInactiveTabPane,
122122
...restProps,
123123
} = props;
@@ -155,7 +155,7 @@ export default class Tabs extends React.Component {
155155
<div
156156
className={cls}
157157
style={props.style}
158-
{...restProps}
158+
{...pickAttrs(restProps)}
159159
>
160160
{contents}
161161
</div>

0 commit comments

Comments
 (0)