CSS not included in dist package

[roderickhsiao]

The latest version no longer include assets folder in the package

tested at version 7.0.8

it moves to /dist folder now, not sure this is expected as the documentation still points us to the assets folder.

[benjycui]

https://unpkg.com/[email protected]/dist/

[paranoidjk]

https://unpkg.com/[email protected]/assets/

[nadeemja]

Having the same problem. Not sure how the links above help. Am I supposed to download the file and put it somewhere in my codebase? (v8.3.0)

[paranoidjk]

@nadeemja Sorry for the trouble. I have fixed it just now，please try [email protected].

[nadeemja]

Hi @paranoidjk !

Thanks for the quick response. Very impressive.

Unfortunately it didn't work.

I ran yarn remove rc-slider and then yarn add rc-slider.

[paranoidjk]

@nadeemja see https://unpkg.com/[email protected]/dist/

[nadeemja]

@paranoidjk

I don't understand what you want me to do.

Do I need to handle the css file separately?

[paranoidjk]

@nadeemja What's your problem?

My answer is for this issue, see the issue title: CSS not included in dist package #271, and i fixed it.

[nadeemja]

Yes. My problem is that the css is not included when installing the package. There is not assets folder, not even in 8.3.1

[paranoidjk]

@nadeemja If you require from npm, you sould load style manually, see https://github.com/react-component/slider/blob/master/examples/slider.js#L2

[nadeemja]

Yes, I understand - but the file does not exist.

Do you mean to say that we must manually download the file?

[paranoidjk]

@nadeemja I checked it, right now i only published css to npm, so you can do:

import 'rc-slider/assets/index.css';

do you need less? Please let me know if it is necessary.

[paranoidjk]

@nadeemja I think users no need to import less, just use css, since you have to compile less to css eventually.

[paranoidjk]

@nadeemja see usage doc in readme: https://github.com/react-component/slider#usage 😄

[nadeemja]

@paranoidjk

Okay. Let me explain.

1. I ran yarn add rc-slider.

2. I open node_modules/rc-slider.

3. There is no assets folder in node_modules/rc-slider.

4. Therefore, import 'rc-slider/assets/index.css'; gives error unable to resolve module.

I do not need Less. I'm just saying that the .css file is missing. :)

[paranoidjk]

@nadeemja What's your version of rc-slider?

You could see from https://unpkg.com/[email protected]/ , There do have assets folder.

PS. what is unpkg? see https://unpkg.com/#/

[nadeemja]

I'm using 8.3.1.

Perhaps it's a problem with Yarn.

Have you tested with Yarn?
https://github.com/yarnpkg/yarn

[paranoidjk]

@nadeemja Yarn won't change the package files.

[nadeemja]

I know. But then why is the assets folder not installed into node_modules/rc-slider?