feat: refactor useWatch type
#608
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 15 15
Lines 1142 1142
Branches 245 245
=======================================
Hits 1140 1140
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zombieJ
reviewed
Aug 2, 2023
| @@ -13,18 +13,26 @@ export type DeepNamePath< | |||
| ? ParentNamePath['length'] extends 0 | |||
| ? Store | BaseNamePath // Return `BaseNamePath` instead of array if `ParentNamePath` is empty | |||
| : Store extends any[] | |||
| ? [...ParentNamePath, number] // Connect path | |||
| ? readonly [...ParentNamePath, number] // Connect path | |||
There was a problem hiding this comment.
zombieJ
reviewed
Aug 2, 2023
| @@ -271,10 +271,28 @@ describe('useWatch', () => { | |||
| const demo3 = Form.useWatch(['demo1', 'demo2', 'demo3'], form); | |||
| const demo4 = Form.useWatch(['demo1', 'demo2', 'demo3', 'demo4'], form); | |||
| const demo5 = Form.useWatch(['demo1', 'demo2', 'demo3', 'demo4', 'demo5'], form); | |||
| const more = Form.useWatch(['age', 'name', 'gender'], form); | |||
| const demo6 = Form.useWatch(['demo1', 'demo2', 'demo3', 'demo4', 'demo5', 'demo6'], form); | |||
There was a problem hiding this comment.
这里测试不会有效果，要加个类型推断做匹配：
const demoX: XXX = Form.useWatch(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.