Skip to content

Look for other possible "missing PICO_CONFIG" lines, and make message more obvious #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Look for other possible "missing PICO_CONFIG" lines, and make message more obvious #2477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/extract_configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,9 @@ def ValidateAttrs(config_name, config_attrs, file_path, linenum):
chips_resolved_defines = defaultdict(dict)
for applicable, all_defines in chips_all_defines.items():
for d in all_defines:
if d not in all_config_names and d.startswith("PICO_"):
logger.warning("Potential unmarked PICO define {}".format(d))
for define_prefix in ('PICO', 'PARAM', 'CYW43'):
if d not in all_config_names and d.startswith(define_prefix+'_'):
logger.warning("#define {} is potentially missing a {}: entry".format(d, BASE_CONFIG_NAME))
resolved_defines = chips_resolved_defines[applicable]
# resolve "nested defines" - this allows e.g. USB_DPRAM_MAX to resolve to USB_DPRAM_SIZE which is set to 4096 (which then matches the relevant PICO_CONFIG entry)
for val in all_defines[d]:
Expand Down
Loading