Skip to content

Commit 922454c

Browse files
Nicholas Kazlauskasalexdeucher
authored andcommitted
drm/amd/display: Fix duplicating scaling/underscan connector state
[Why] These properties aren't being carried over when the atomic state. This tricks atomic check and commit tail into performing underscan and scaling operations when they aren't needed. With the patch that forced scaling/RMX_ASPECT on by default this results in many unnecessary surface updates and hangs under certain conditions. [How] Duplicate the properties. Fixes: 91b66c4 ("drm/amd/display: Set RMX_ASPECT as default") Signed-off-by: Nicholas Kazlauskas <[email protected]> Acked-by: Alex Deucher <[email protected]> Reviewed-by: Leo Li <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 65276f2 commit 922454c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3240,6 +3240,10 @@ amdgpu_dm_connector_atomic_duplicate_state(struct drm_connector *connector)
32403240

32413241
new_state->freesync_capable = state->freesync_capable;
32423242
new_state->abm_level = state->abm_level;
3243+
new_state->scaling = state->scaling;
3244+
new_state->underscan_enable = state->underscan_enable;
3245+
new_state->underscan_hborder = state->underscan_hborder;
3246+
new_state->underscan_vborder = state->underscan_vborder;
32433247
new_state->max_bpc = state->max_bpc;
32443248

32453249
return &new_state->base;

0 commit comments

Comments
 (0)