Skip to content

[Feature(?) Request] Eliminate compiler warnings about deprecated [-Wvolatile] operations #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmalnati opened this issue Feb 7, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@dmalnati
Copy link

dmalnati commented Feb 7, 2025

Is your feature request related to a problem? Please describe.
Compiler warnings about deprecated [-Wvolatile] operations, feels like those shouldn't exist.

C:/Users/dougl/git/Webserver/ext/picoinf/ext/FreeRTOS-Kernel/portable/ThirdParty/GCC/RP2040/include/portmacro.h: In function 'void vPortRecursiveLock(uint32_t, spin_lock_t*, BaseType_t)':
C:/Users/dougl/git/Webserver/ext/picoinf/ext/FreeRTOS-Kernel/portable/ThirdParty/GCC/RP2040/include/portmacro.h:230:51: warning: '++' expression of 'volatile'-qualified type is deprecated [-Wvolatile]
  230 |                 ucRecursionCountByLock[ ulLockNum ]++;
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
C:/Users/dougl/git/Webserver/ext/picoinf/ext/FreeRTOS-Kernel/portable/ThirdParty/GCC/RP2040/include/portmacro.h:244:50: warning: '--' expression of 'volatile'-qualified type is deprecated [-Wvolatile]
  244 |         if( !--ucRecursionCountByLock[ ulLockNum ] )
      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^

Describe the solution you'd like
I would like a clean build with -Wall, etc.

Describe alternatives you've considered
None.

How many devices will this feature impact?
Personal.

What are your project timelines?
Personal.

Additional context
I am upgrading to the pico-sdk 2.1.0, and part of that was guidance (in the 2.0.0 upgrade) to use this rpi-fork FreeRTOS-Kernel repo specifically. Previously I was using the original FreeRTOS-Kernel, and there were no compiler warnings on build.

I don't know what, if anything, is special about this fork, but I'd like to both follow guidance and have a clean build.

If I'm misunderstanding something please shout.

Thanks.

Doug

@dmalnati dmalnati added the enhancement New feature or request label Feb 7, 2025
@lurch
Copy link

lurch commented Feb 10, 2025

The code from this rpi-fork has now been migrated back upstream - see raspberrypi/pico-feedback#442

@dmalnati
Copy link
Author

dmalnati commented Feb 10, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants