Skip to content

fix(ngx-diff): add styles to exports of package.json #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [8.0.2](https://github.com/rars/ngx-diff/compare/v8.0.1...v8.0.2) (2024-03-27)


### Bug Fixes

* **ngx-diff:** add styles to exports of package.json ([911c864](https://github.com/rars/ngx-diff/commit/911c8642cfc81b4d305aab7ef536c43a6bbc1ce4)), closes [#78](https://github.com/rars/ngx-diff/issues/78)

### [8.0.1](https://github.com/rars/ngx-diff/compare/v8.0.0...v8.0.1) (2024-03-15)


Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-diff",
"version": "8.0.1",
"version": "8.0.2",
"type": "module",
"scripts": {
"ng": "ng",
Expand Down
7 changes: 5 additions & 2 deletions projects/ngx-diff/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-diff",
"version": "8.0.1",
"version": "8.0.2",
"peerDependencies": {
"@angular/common": ">=17.0.0",
"@angular/core": ">=17.0.0",
Expand All @@ -23,5 +23,8 @@
"bugs": {
"url": "https://github.com/rars/ngx-diff/issues"
},
"homepage": "https://github.com/rars/ngx-diff#readme"
"homepage": "https://github.com/rars/ngx-diff#readme",
"exports": {
"./styles/": "./styles/"
Copy link

@mshima mshima Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exporting directories is deprecated and not supported in node anymore.
Since I am using webpack, it’s not complaining.

So I recommend to export like "./styles/*": "./styles/*.css" or "./css/*": "./styles/*.css" to avoid problems in the future.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this suggestion, have updated in #81

}
}