[backport v2.11] Refactors keyValueArgs handling for improved efficiency (#928) #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit decouples parseFromRawArgs from the keyValueArgs receiver. Simplifies the logic and results in improved performance. Updates getKubeAPIServerArgs to return errors to the UI. Follow up to rancher#925
apoorvajagtap
force-pushed
the
0.7-refactor-mutator
branch
from
34f646d to
64b70f9
Compare
jiaqiluo
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #925
Backport of #928
Issue: Related to rancher/rancher#50340
Problem
Solution
This PR:
parseFromRawArgsfrom the keyValueArgs receiver.getKubeAPIServerArgsto return errors to the UI.Per benchmark, this approach improves the performance by ~10-12%.
CheckList