Skip to content

Commit bc6d1e4

Browse files
authored
fix: yarn getPeerDependencies doesnt work on private reporsitories wh… (#1472)
1 parent ce38291 commit bc6d1e4

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

src/lib/getIgnoredUpgradesDueToPeerDeps.ts

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { intersects, satisfies } from 'semver'
1+
import { intersects, minVersion, satisfies, validRange } from 'semver'
22
import { IgnoredUpgradeDueToPeerDeps } from '../types/IgnoredUpgradeDueToPeerDeps'
33
import { Index } from '../types/IndexType'
44
import { Options } from '../types/Options'
@@ -24,7 +24,19 @@ export async function getIgnoredUpgradesDueToPeerDeps(
2424
peerDependencies: undefined,
2525
loglevel: 'silent',
2626
})
27-
const upgradedPeerDependenciesLatest = await getPeerDependenciesFromRegistry(upgradedLatestVersions, options)
27+
const upgradedPeerDependenciesLatest = await getPeerDependenciesFromRegistry(
28+
Object.fromEntries(
29+
Object.entries(upgradedLatestVersions).map(([packageName, versionSpec]) => {
30+
return [
31+
packageName,
32+
// git urls and other non-semver versions are ignored.
33+
// Make sure versionSpec is a valid semver range, otherwise minVersion will throw.
34+
validRange(versionSpec) ? (minVersion(versionSpec)?.version ?? versionSpec) : versionSpec,
35+
]
36+
}),
37+
),
38+
options,
39+
)
2840
return Object.entries(upgradedLatestVersions)
2941
.filter(([pkgName, newVersion]) => upgraded[pkgName] !== newVersion)
3042
.reduce((accum, [pkgName, newVersion]) => {

0 commit comments

Comments
 (0)