Fix duplicated test names for image pack helpers #2737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gauravtiwari emergency commit
in my last pull request to add missing helper functions I completely missed that I accidentally left duplicated test names in the
helper_test.rbwhen I copied the structure of the other asset path tests for the image pack versionsAlso added the use of github relative links in docs so that instructions aren't pointing at incorrect assets because the link in the
assetsdocs to an old version of the helper test file is how I came across the duplication when switching to the master versionIf the docs updates needs to be a separate PR I can split them out, but the test file needs to be updated ASAP