Simplify build / install tool (bun / yarn / npm) logic #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior logic for selecting a tool (bun / yarn / npm) scaled poorly with many tools (and the JS ecosystem has many tools). This also includes a logic fix for when bun is installed but a package-lock.json is present.
ksylvest
force-pushed
the
ksylvest/npm-build-tool-selection-fix
branch
from
2920db0 to
092ef9f
Compare
ksylvest
changed the title
This was referenced Jan 5, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior logic for selecting a tool (either
bun/yarn/npm) became confusing with multiple tools (and the JS ecosystem has many tools). This simplifies the logic and fixes a subtle bug where apackage-lock.jsonis ignored if bun is installed. This issue seems to have been introduced with:https://github.com/rails/jsbundling-rails/pull/179/files