Use iife format for Rollup #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both esbuild and Webpack output a self-executing function.
This PR updates Rollup to do the same.
With the current
es
format, Rollup can set a lot of variables and functions on thewindow
object. You can see this with thechart.js
package and the followingapplication.js
:With esbuild and Webpack, this only sets an additional
Chart
variable onwindow
. With Rollup, it sets 400+ more properties.