Added test case

Fix sql

Use database when constructing object ID argument

Wrap insert in transaction

Update temp_test_sqlserver.rb

Update temp_test_sqlserver.rb

Update temp_test_sqlserver.rb

Update temp_test_sqlserver.rb

Timeout CI tests after 10 minutes

Update temp_test_sqlserver.rb

Verbose

Debug

Update temp_test_sqlserver.rb

Debug

Update temp_test_sqlserver.rb

Debug

Cleanup

Update adapter_test_sqlserver.rb

Update adapter_test_sqlserver.rb

Update adapter_test_sqlserver.rb

Update adapter_test_sqlserver.rb

Author: aidanharan

.github/workflows/ci.yml

@@ -6,6 +6,7 @@ jobs:
   test:
     name: Run test suite
     runs-on: ubuntu-latest
+    timeout-minutes: 10
 
     env:
       COMPOSE_FILE: docker-compose.ci.yml

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -571,6 +571,7 @@ def column_definitions(table_name)
         end
 
         def column_definitions_sql(database, identifier)
+          database = "TEMPDB" if identifier.temporary_table?
           schema_name = "schema_name()"
 
           if prepared_statements
@@ -581,12 +582,8 @@ def column_definitions_sql(database, identifier)
             schema_name = quote(identifier.schema) if identifier.schema.present?
           end
 
-          object_id_arg = identifier.schema.present? ? "CONCAT(#{schema_name},'.',#{object_name})" : object_name
-
-          if identifier.temporary_table?
-            database = "TEMPDB"
-            object_id_arg = "CONCAT('#{database}','..',#{object_name})"
-          end
+          object_id_arg = identifier.schema.present? ? "CONCAT('.',#{schema_name},'.',#{object_name})" : "CONCAT('..',#{object_name})"
+          object_id_arg = "CONCAT('#{database}',#{object_id_arg})"
 
           %{
             SELECT

test/cases/adapter_test_sqlserver.rb

@@ -233,6 +233,31 @@ class AdapterTestSQLServer < ActiveRecord::TestCase
     it "return an empty array when calling #identity_columns for a table_name with no identity" do
       _(connection.send(:identity_columns, Subscriber.table_name)).must_equal []
     end
+
+    it "identity insert enabled for cross database insert" do
+      arunit_connection = Dog.lease_connection
+      arunit2_connection = OtherDog.lease_connection
+
+      arunit_database = arunit_connection.pool.db_config.database
+      arunit2_database = arunit2_connection.pool.db_config.database
+
+      sql = <<~SQL
+        INSERT INTO #{arunit2_database}.dbo.dogs(id) SELECT id FROM #{arunit_database}.dbo.dogs
+      SQL
+
+      OtherDog.destroy_all
+      
+      #
+      # assert Dog.count, 1
+      # assert OtherDog.count, 0
+
+      assert_nothing_raised do
+        arunit_connection.execute(sql)
+      end
+
+      # assert Dog.count, 1
+      # assert OtherDog.count, 1
+    end
   end
 
   describe "quoting" do

test/cases/temp_test_sqlserver.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require "cases/helper_sqlserver"
+require "models/dog"
+require "models/other_dog"
+
+class TempTestSQLServer < ActiveRecord::TestCase
+  # it "assert true" do
+  #   assert true
+  # end
+end