Skip to content

Conversation

@carlsmedstad
Copy link
Contributor

See discussion: #14775

Proposed Changes

This allows e.g. dynamic shovels to authenticate with brokers using external SASL authentication.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.

  • Mandatory: I (or my employer/client) have have signed the CA (see https://github.com/rabbitmq/cla)
  • I have read the CONTRIBUTING.md document
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

Disclaimer: No Erlang experience and not familiar with the codebase - I might have very well missed something.

Thanks!

@ansd ansd changed the title Support external SASL authentication in AMQP 1.0 client Support external SASL in AMQP 1.0 client URI Oct 30, 2025
@michaelklishin michaelklishin added this to the 4.3.0 milestone Oct 30, 2025
@michaelklishin
Copy link
Collaborator

Thank you, @carlsmedstad @ansd.

@michaelklishin michaelklishin merged commit 5ecbc73 into rabbitmq:main Oct 30, 2025
289 checks passed
@michaelklishin
Copy link
Collaborator

@carlsmedstad this can be considered a trivial change but we'd appreciate if you could sign our CLA (electronically, using Box Sign) for this and any future contributions. Thank you.

@carlsmedstad
Copy link
Contributor Author

@michaelklishin As far as I'm aware I signed it before creating the PR, but I might've made a mistake.

@carlsmedstad carlsmedstad deleted the ampq-1.0-client-sasl-external branch October 30, 2025 19:50
michaelklishin added a commit that referenced this pull request Oct 30, 2025
Support external SASL in AMQP 1.0 client URI (backport #14863)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants