Skip to content

Commit b795d61

Browse files
committed
rabbit_feature_flags: Remove duplicated code
... in the `rabbit_feature_flags` module. `rabbit_ff_controller` already provides functions to list nodes.
1 parent 8b88e45 commit b795d61

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

deps/rabbit/src/rabbit_feature_flags.erl

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1045,34 +1045,22 @@ mark_as_enabled_locally(FeatureName, IsEnabled) ->
10451045
%% Coordination with remote nodes.
10461046
%% -------------------------------------------------------------------
10471047

1048-
-ifndef(TEST).
10491048
-spec remote_nodes() -> [node()].
10501049
%% @private
10511050

10521051
remote_nodes() ->
1053-
mnesia:system_info(db_nodes) -- [node()].
1052+
rabbit_ff_controller:all_nodes() -- [node()].
10541053

10551054
-spec running_remote_nodes() -> [node()].
10561055
%% @private
10571056

10581057
running_remote_nodes() ->
1059-
mnesia:system_info(running_db_nodes) -- [node()].
1060-
-else.
1058+
rabbit_ff_controller:running_nodes() -- [node()].
1059+
1060+
-ifdef(TEST).
10611061
-define(PT_OVERRIDDEN_NODES, {?MODULE, overridden_nodes}).
10621062
-define(PT_OVERRIDDEN_RUNNING_NODES, {?MODULE, overridden_running_nodes}).
10631063

1064-
remote_nodes() ->
1065-
case get_overriden_nodes() of
1066-
undefined -> mnesia:system_info(db_nodes) -- [node()];
1067-
Nodes -> Nodes -- [node()]
1068-
end.
1069-
1070-
running_remote_nodes() ->
1071-
case get_overriden_running_nodes() of
1072-
undefined -> mnesia:system_info(running_db_nodes) -- [node()];
1073-
Nodes -> Nodes -- [node()]
1074-
end.
1075-
10761064
override_nodes(Nodes) ->
10771065
persistent_term:put(?PT_OVERRIDDEN_NODES, Nodes).
10781066

0 commit comments

Comments
 (0)