Fix all dependencies for the dialyzer

This is the latest commit in the series, it fixes (almost) all the
problems with missing and circular dependencies for typing.

The only 2 unsolved problems are:

- `lg` dependency for `rabbit` - the problem is that it's the only
  dependency that contains NIF. And there is no way to make dialyzer
  ignore it - looks like unknown check is not suppressable by dialyzer
  directives. In the future making `lg` a proper dependency can be a
  good thing anyway.

- some missing elixir function in `rabbitmq_cli` (CSV, JSON and
  logging related).

- `eetcd` dependency for `rabbitmq_peer_discovery_etcd` - this one
  uses sub-directories in `src/`, which confuses dialyzer (or our bazel
  machinery is not able to properly handle it). I've tried the latest
  rules_erlang which flattens directory for .beam files, but it wasn't
  enough for dialyzer - it wasn't able to find core erlang files. This
  is a niche plugin and an unusual dependency, so probably not worth
  investigating further.

(cherry picked from commit 949b535)
(cherry picked from commit 3a3ff30)

# Conflicts:
#	deps/rabbit/BUILD.bazel
#	deps/rabbit/src/rabbit_access_control.erl
#	deps/rabbit/src/rabbit_exchange.erl
#	deps/rabbit_common/src/rabbit_misc.erl
#	deps/rabbitmq_consistent_hash_exchange/BUILD.bazel
#	deps/rabbitmq_mqtt/BUILD.bazel

Author: binarin

deps/rabbit/BUILD.bazel

@@ -10,6 +10,7 @@ load(
     "rabbitmq_integration_suite",
     "rabbitmq_suite",
     "rabbitmq_test_helper",
+    "without",
 )
 load(":bats.bzl", "bats")
 
@@ -213,7 +214,8 @@ plt(
 )
 
 dialyze(
-    dialyzer_opts = RABBITMQ_DIALYZER_OPTS,
+    # A few `lg` functions are unknown
+    dialyzer_opts = without("-Wunknown", RABBITMQ_DIALYZER_OPTS),
     plt = ":base_plt",
 )
 
@@ -519,9 +521,12 @@ rabbitmq_suite(
     additional_srcs = [
         "test/mirrored_supervisor_SUITE_gs.erl",
     ],
+<<<<<<< HEAD
     deps = [
         "//deps/rabbit_common:erlang_app",
     ],
+=======
+>>>>>>> 3a3ff308aa (Fix all dependencies for the dialyzer)
 )
 
 rabbitmq_suite(

deps/rabbit/apps/rabbitmq_prelaunch/BUILD.bazel

@@ -2,8 +2,8 @@ load("@rules_erlang//:xref2.bzl", "xref")
 load("@rules_erlang//:dialyze.bzl", "dialyze", "plt")
 load(
     "//:rabbitmq.bzl",
-    "RABBITMQ_DIALYZER_OPTS",
     "APP_VERSION",
+    "RABBITMQ_DIALYZER_OPTS",
     "rabbitmq_app",
     "rabbitmq_suite",
 )
@@ -41,7 +41,10 @@ xref(
 
 plt(
     name = "base_plt",
-    apps = ["runtime_tools", "eunit"],
+    apps = [
+        "runtime_tools",
+        "eunit",
+    ],
     plt = "//:base_plt",
     deps = DEPS + RUNTIME_DEPS + [
         "@systemd//:erlang_app",
@@ -50,8 +53,8 @@ plt(
 )
 
 dialyze(
-    plt = ":base_plt",
     dialyzer_opts = RABBITMQ_DIALYZER_OPTS,
+    plt = ":base_plt",
 )
 
 suites = [

deps/rabbit/src/rabbit_access_control.erl

@@ -16,12 +16,15 @@
 
 %%----------------------------------------------------------------------------
 
+<<<<<<< HEAD
 -export_type([permission_atom/0]).
 
 -type permission_atom() :: 'configure' | 'read' | 'write'.
 
 %%----------------------------------------------------------------------------
 
+=======
+>>>>>>> 3a3ff308aa (Fix all dependencies for the dialyzer)
 -spec check_user_pass_login
         (rabbit_types:username(), rabbit_types:password()) ->
             {'ok', rabbit_types:user()} |
@@ -179,7 +182,7 @@ create_vhost_access_authz_data(PeerAddr, Context) ->
     maps:merge(PeerAddr, Context).
 
 -spec check_resource_access
-        (rabbit_types:user(), rabbit_types:r(atom()), permission_atom(), rabbit_types:authz_context()) ->
+        (rabbit_types:user(), rabbit_types:r(atom()), rabbit_types:permission_atom(), rabbit_types:authz_context()) ->
             'ok' | rabbit_types:channel_exit().
 
 check_resource_access(User, R = #resource{kind = exchange, name = <<"">>},

deps/rabbit/src/rabbit_channel.erl

@@ -227,7 +227,7 @@
 
 -export_type([channel_number/0]).
 
--type channel_number() :: non_neg_integer().
+-type channel_number() :: rabbit_types:channel_number().
 
 -export_type([channel/0]).
 

deps/rabbit/src/rabbit_exchange.erl

@@ -22,9 +22,14 @@
 %%----------------------------------------------------------------------------
 
 -export_type([name/0, type/0]).
+<<<<<<< HEAD
 
 -type name() :: rabbit_types:r('exchange').
 -type type() :: atom().
+=======
+-type name() :: rabbit_types:exchange_name().
+-type type() :: rabbit_types:exchange_type().
+>>>>>>> 3a3ff308aa (Fix all dependencies for the dialyzer)
 -type fun_name() :: atom().
 
 %%----------------------------------------------------------------------------

deps/rabbit/src/rabbit_guid.erl

@@ -25,7 +25,7 @@
 
 -export_type([guid/0]).
 
--type guid() :: binary().
+-type guid() :: rabbit_types:guid().
 
 %%----------------------------------------------------------------------------
 

deps/rabbit/src/rabbit_router.erl

@@ -15,7 +15,7 @@
 
 -export_type([routing_key/0, match_result/0]).
 
--type routing_key() :: binary().
+-type routing_key() :: rabbit_types:routing_key().
 -type match_result() :: [rabbit_types:binding_destination()].
 
 %%----------------------------------------------------------------------------

deps/rabbit/src/vhost.erl

@@ -34,7 +34,7 @@
 
 -define(record_version, vhost_v2).
 
--type(name() :: binary()).
+-type(name() :: rabbit_types:vhost()).
 
 -type(metadata_key() :: atom()).
 

deps/rabbit_common/BUILD.bazel

@@ -2,6 +2,7 @@ load("@rules_erlang//:xref2.bzl", "xref")
 load("@rules_erlang//:dialyze.bzl", "dialyze", "plt")
 load(
     "//:rabbitmq.bzl",
+    "RABBITMQ_DIALYZER_OPTS",
     "assert_suites",
     "rabbitmq_app",
     "rabbitmq_suite",
@@ -55,6 +56,7 @@ RUNTIME_DEPS = [
     "@thoas//:erlang_app",
     "@recon//:erlang_app",
     "@credentials_obfuscation//:erlang_app",
+    "@ranch//:erlang_app",
 ]
 
 APP_NAME = "rabbit_common"
@@ -89,6 +91,8 @@ EXTRA_APPS = [
     "syntax_tools",
     "tools",
     "xmerl",
+    "runtime_tools",
+    "os_mon",
 ]
 
 rabbitmq_app(
@@ -106,23 +110,17 @@ rabbitmq_app(
     runtime_deps = RUNTIME_DEPS,
 )
 
-xref(
-    additional_libs = [
-        "@ranch//:erlang_app",
-    ],
-)
+xref()
 
 plt(
     name = "base_plt",
-    apps = [
-        "mnesia",
-        "crypto",
-        "ssl",
-    ] + EXTRA_APPS,
+    apps = EXTRA_APPS + ["mnesia"],
     plt = "//:base_plt",
+    deps = RUNTIME_DEPS,
 )
 
 dialyze(
+    dialyzer_opts = RABBITMQ_DIALYZER_OPTS,
     plt = ":base_plt",
 )
 

deps/rabbit_common/src/rabbit_authz_backend.erl

@@ -50,7 +50,7 @@
 %%     Something went wrong. Log and die.
 -callback check_resource_access(rabbit_types:auth_user(),
                                 rabbit_types:r(atom()),
-                                rabbit_access_control:permission_atom(),
+                                rabbit_types:permission_atom(),
                                 rabbit_types:authz_context()) ->
     boolean() | {'error', any()}.
 
@@ -63,7 +63,7 @@
 %%     Something went wrong. Log and die.
 -callback check_topic_access(rabbit_types:auth_user(),
     rabbit_types:r(atom()),
-    rabbit_access_control:permission_atom(),
+    rabbit_types:permission_atom(),
     rabbit_types:topic_access_context()) ->
     boolean() | {'error', any()}.