rabbit_feature_flags: Export rabbit_ff_controller functions for internal use

The two exported functions are used by the testsuite. They should be
exported when `TEST` is defined only, but the way mixed-version testing
is implemented in Bazel forces us to export them.

(cherry picked from commit 80da804)

Author: dumbbell

deps/rabbit/src/rabbit_feature_flags.erl

@@ -2072,78 +2072,6 @@ do_sync_feature_flags_with_node([FeatureFlag | Rest]) ->
 do_sync_feature_flags_with_node([]) ->
     ok.
 
-<<<<<<< HEAD
--spec get_forced_feature_flag_names() -> [feature_name()] | undefined.
-%% @private
-%% @doc
-%% Returns the (possibly empty) list of feature flags the user want
-%% to enable out-of-the-box when starting a node for the first time.
-%%
-%% Without this, the default is to enable all the supported feature
-%% flags.
-%%
-%% There are two ways to specify that list:
-%% <ol>
-%% <li>Using the `$RABBITMQ_FEATURE_FLAGS' environment variable; for
-%%   instance `RABBITMQ_FEATURE_FLAGS=quorum_queue,mnevis'.</li>
-%% <li>Using the `forced_feature_flags_on_init' configuration parameter;
-%%   for instance
-%%   `{rabbit, [{forced_feature_flags_on_init, [quorum_queue, mnevis]}]}'.</li>
-%% </ol>
-%%
-%% The environment variable has precedence over the configuration
-%% parameter.
-
-get_forced_feature_flag_names() ->
-    Ret = case get_forced_feature_flag_names_from_env() of
-              undefined -> get_forced_feature_flag_names_from_config();
-              List      -> List
-          end,
-    case Ret of
-        undefined -> ok;
-        []        -> rabbit_log_feature_flags:info(
-                       "Feature flags: automatic enablement of feature "
-                       "flags disabled (i.e. none will be enabled "
-                       "automatically)");
-        _         -> rabbit_log_feature_flags:info(
-                       "Feature flags: automatic enablement of feature "
-                       "flags limited to the following list: ~p", [Ret])
-    end,
-    Ret.
-
--spec get_forced_feature_flag_names_from_env() -> [feature_name()] | undefined.
-%% @private
-
-get_forced_feature_flag_names_from_env() ->
-    case rabbit_prelaunch:get_context() of
-        #{forced_feature_flags_on_init := ForcedFFs}
-          when is_list(ForcedFFs) ->
-            ForcedFFs;
-        _ ->
-            undefined
-    end.
-
--spec get_forced_feature_flag_names_from_config() -> [feature_name()] | undefined.
-%% @private
-
-get_forced_feature_flag_names_from_config() ->
-    Value = application:get_env(rabbit,
-                                forced_feature_flags_on_init,
-                                undefined),
-    case Value of
-        undefined ->
-            Value;
-        _ when is_list(Value) ->
-            case lists:all(fun is_atom/1, Value) of
-                true  -> Value;
-                false -> undefined
-            end;
-        _ ->
-            undefined
-    end.
-
-=======
->>>>>>> 9fb4e6754e (rabbit_feature_flags: Support virgin node init with feature flags v2)
 -spec verify_which_feature_flags_are_actually_enabled() ->
     ok | {error, any()} | no_return().
 %% @private

deps/rabbit/src/rabbit_ff_controller.erl

@@ -44,7 +44,9 @@
          start_link/0,
          rpc_call/5,
          all_nodes/0,
-         running_nodes/0]).
+         running_nodes/0,
+         collect_inventory_on_nodes/1, collect_inventory_on_nodes/2,
+         mark_as_enabled_on_nodes/4]).
 
 %% gen_statem callbacks.
 -export([callback_mode/0,