Skip to content

Commit 1f6538e

Browse files
committed
Add protocol and version to observation attributes
1 parent 53a2d2e commit 1f6538e

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

src/main/java/com/rabbitmq/client/observation/micrometer/DefaultPublishObservationConvention.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ private String exchange(String destination) {
5656
public KeyValues getLowCardinalityKeyValues(PublishContext context) {
5757
return KeyValues.of(
5858
LowCardinalityTags.MESSAGING_OPERATION.withValue("publish"),
59-
LowCardinalityTags.MESSAGING_SYSTEM.withValue("rabbitmq"));
59+
LowCardinalityTags.MESSAGING_SYSTEM.withValue("rabbitmq"),
60+
LowCardinalityTags.NET_PROTOCOL_NAME.withValue("amqp"),
61+
LowCardinalityTags.NET_PROTOCOL_VERSION.withValue("0.9.1"));
6062
}
6163

6264
@Override

src/main/java/com/rabbitmq/client/observation/micrometer/RabbitMqObservationDocumentation.java

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,23 @@ public String asString() {
107107
public String asString() {
108108
return "messaging.operation";
109109
}
110-
}
110+
},
111+
112+
NET_PROTOCOL_NAME {
113+
114+
@Override
115+
public String asString() {
116+
return "net.protocol.name";
117+
}
118+
},
119+
120+
NET_PROTOCOL_VERSION {
121+
122+
@Override
123+
public String asString() {
124+
return "net.protocol.version";
125+
}
126+
},
111127
}
112128

113129
/** High cardinality tags. */

0 commit comments

Comments
 (0)