Coerce upstream set definition to proplists

So that it passes validation.

Closes #67.

[#154751618]

Author: michaelklishin

src/rabbit_federation_parameters.erl

@@ -47,7 +47,8 @@ unregister() ->
         {Class, Name} <- ?RUNTIME_PARAMETERS],
     ok.
 
-validate(_VHost, <<"federation-upstream-set">>, Name, Term, _User) ->
+validate(_VHost, <<"federation-upstream-set">>, Name, Term0, _User) ->
+    Term = [rabbit_data_coercion:to_proplist(Upstream) || Upstream <- Term0],
     [rabbit_parameter_validation:proplist(
        Name,
        [{<<"upstream">>, fun rabbit_parameter_validation:binary/2, mandatory} |

test/unit_inbroker_SUITE.erl

@@ -18,6 +18,7 @@
 
 -include_lib("common_test/include/ct.hrl").
 -include_lib("rabbit_common/include/rabbit.hrl").
+-include_lib("eunit/include/eunit.hrl").
 
 -include("rabbit_federation.hrl").
 
@@ -37,7 +38,8 @@ groups() ->
           serialisation,
           scratch_space,
           remove_credentials,
-          get_connection_name
+          get_connection_name,
+          upstream_set_validation
         ]}
     ].
 
@@ -163,6 +165,21 @@ get_connection_name(_Config) ->
     ),
     ok.
 
+upstream_set_validation(_Config) ->
+    ?assertEqual(rabbit_federation_parameters:validate(<<"/">>, <<"federation-upstream-set">>,
+                                         <<"a-name">>,
+                                          [[{<<"upstream">>, <<"devtest1">>}],
+                                           [{<<"upstream">>, <<"devtest2">>}]],
+                                         <<"acting-user">>),
+                 [[ok], [ok]]),
+    ?assertEqual(rabbit_federation_parameters:validate(<<"/">>, <<"federation-upstream-set">>,
+                                         <<"a-name">>,
+                                          [#{<<"upstream">> => <<"devtest3">>},
+                                           #{<<"upstream">> => <<"devtest4">>}],
+                                         <<"acting-user">>),
+                 [[ok], [ok]]),
+    ok.
+
 with_exchanges(Fun) ->
     rabbit_exchange:declare(r(?US_NAME), fanout, false, false, false, [],
                             <<"acting-user">>),