* Stop using amq.fanout in tests

lukebakken · lukebakken · commit cc4d5206ab2e · 2024-05-01T09:47:56.000-07:00
diff --git a/build.ps1 b/build.ps1
@@ -25,7 +25,8 @@ if ($RunTests)
         dotnet test $csproj_file --environment 'RABBITMQ_LONG_RUNNING_TESTS=true' --no-restore --no-build --logger "console;verbosity=detailed"
         if ($LASTEXITCODE -ne 0)
         {
-            Write-Host "[WARNING] tests errored, exiting" -Foreground "Red"
+            Write-Host "[ERROR] tests errored, exiting" -Foreground "Red"
+            Exit 1
         }
         else
         {
diff --git a/projects/Test/Integration/ConnectionRecovery/TestExchangeRecovery.cs b/projects/Test/Integration/ConnectionRecovery/TestExchangeRecovery.cs
@@ -56,25 +56,29 @@ public async Task TestExchangeRecoveryTest()
         public async Task TestExchangeToExchangeBindingRecovery()
         {
             string q = (await _channel.QueueDeclareAsync("", false, false, false)).QueueName;
-            string x1 = "amq.fanout";
-            string x2 = GenerateExchangeName();
 
-            await _channel.ExchangeDeclareAsync(x2, "fanout");
-            await _channel.ExchangeBindAsync(x1, x2, "");
-            await _channel.QueueBindAsync(q, x1, "");
+            string ex_source = GenerateExchangeName();
+            string ex_destination = GenerateExchangeName();
+
+            await _channel.ExchangeDeclareAsync(ex_source, ExchangeType.Fanout);
+            await _channel.ExchangeDeclareAsync(ex_destination, ExchangeType.Fanout);
+
+            await _channel.ExchangeBindAsync(destination: ex_destination, source: ex_source, "");
+            await _channel.QueueBindAsync(q, ex_destination, "");
 
             try
             {
                 await CloseAndWaitForRecoveryAsync();
                 Assert.True(_channel.IsOpen);
-                await _channel.BasicPublishAsync(x2, "", _encoding.GetBytes("msg"));
+                await _channel.BasicPublishAsync(ex_source, "", _encoding.GetBytes("msg"));
                 await AssertMessageCountAsync(q, 1);
             }
             finally
             {
                 await WithTemporaryChannelAsync(async ch =>
                 {
-                    await ch.ExchangeDeleteAsync(x2);
+                    await ch.ExchangeDeleteAsync(ex_source);
+                    await ch.ExchangeDeleteAsync(ex_destination);
                     await ch.QueueDeleteAsync(q);
                 });
             }
diff --git a/projects/Test/Integration/ConnectionRecovery/TestRecoveryWithDeletedEntities.cs b/projects/Test/Integration/ConnectionRecovery/TestRecoveryWithDeletedEntities.cs
@@ -47,26 +47,30 @@ public TestRecoveryWithDeletedEntities(ITestOutputHelper output) : base(output)
         public async Task TestThatDeletedExchangeBindingsDontReappearOnRecovery()
         {
             string q = (await _channel.QueueDeclareAsync("", false, false, false)).QueueName;
-            string x1 = "amq.fanout";
-            string x2 = GenerateExchangeName();
 
-            await _channel.ExchangeDeclareAsync(x2, "fanout");
-            await _channel.ExchangeBindAsync(x1, x2, "");
-            await _channel.QueueBindAsync(q, x1, "");
-            await _channel.ExchangeUnbindAsync(x1, x2, "");
+            string ex_source = GenerateExchangeName();
+            string ex_destination = GenerateExchangeName();
+
+            await _channel.ExchangeDeclareAsync(ex_source, ExchangeType.Fanout);
+            await _channel.ExchangeDeclareAsync(ex_destination, ExchangeType.Fanout);
+
+            await _channel.ExchangeBindAsync(destination: ex_destination, source: ex_source, "");
+            await _channel.QueueBindAsync(q, ex_destination, "");
+            await _channel.ExchangeUnbindAsync(ex_destination, ex_source, "");
 
             try
             {
                 await CloseAndWaitForRecoveryAsync();
                 Assert.True(_channel.IsOpen);
-                await _channel.BasicPublishAsync(x2, "", _encoding.GetBytes("msg"));
+                await _channel.BasicPublishAsync(ex_source, "", _encoding.GetBytes("msg"));
                 await AssertMessageCountAsync(q, 0);
             }
             finally
             {
                 await WithTemporaryChannelAsync(async ch =>
                 {
-                    await ch.ExchangeDeleteAsync(x2);
+                    await ch.ExchangeDeleteAsync(ex_source);
+                    await ch.ExchangeDeleteAsync(ex_destination);
                     await ch.QueueDeleteAsync(q);
                 });
             }
diff --git a/projects/Test/Integration/TestExchangeDeclare.cs b/projects/Test/Integration/TestExchangeDeclare.cs
@@ -51,6 +51,10 @@ public async Task TestConcurrentExchangeDeclareAndBind()
         {
             var exchangeNames = new ConcurrentBag<string>();
             var tasks = new List<Task>();
+
+            string ex_destination = GenerateExchangeName();
+            await _channel.ExchangeDeclareAsync(exchange: ex_destination, type: "fanout", false, false);
+
             NotSupportedException nse = null;
             for (int i = 0; i < 256; i++)
             {
@@ -61,7 +65,7 @@ async Task f()
                         await Task.Delay(S_Random.Next(5, 50));
                         string exchangeName = GenerateExchangeName();
                         await _channel.ExchangeDeclareAsync(exchange: exchangeName, type: "fanout", false, false);
-                        await _channel.ExchangeBindAsync(destination: "amq.fanout", source: exchangeName, routingKey: "unused");
+                        await _channel.ExchangeBindAsync(destination: ex_destination, source: exchangeName, routingKey: "unused");
                         exchangeNames.Add(exchangeName);
                     }
                     catch (NotSupportedException e)
@@ -84,7 +88,7 @@ async Task f()
                     try
                     {
                         await Task.Delay(S_Random.Next(5, 50));
-                        await _channel.ExchangeUnbindAsync(destination: "amq.fanout", source: exchangeName, routingKey: "unused",
+                        await _channel.ExchangeUnbindAsync(destination: ex_destination, source: exchangeName, routingKey: "unused",
                             noWait: false, arguments: null);
                         await _channel.ExchangeDeleteAsync(exchange: exchangeName, ifUnused: false);
                     }
@@ -99,6 +103,7 @@ await _channel.ExchangeUnbindAsync(destination: "amq.fanout", source: exchangeNa
 
             await AssertRanToCompletion(tasks);
             Assert.Null(nse);
+            await _channel.ExchangeDeleteAsync(exchange: ex_destination);
         }
 
         [Fact]

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@ if ($RunTests)`
`25`	`25`	`dotnet test $csproj_file --environment 'RABBITMQ_LONG_RUNNING_TESTS=true' --no-restore --no-build --logger "console;verbosity=detailed"`
`26`	`26`	`if ($LASTEXITCODE -ne 0)`
`27`	`27`	`{`
`28`		`- Write-Host "[WARNING] tests errored, exiting" -Foreground "Red"`
	`28`	`+ Write-Host "[ERROR] tests errored, exiting" -Foreground "Red"`
	`29`	`+ Exit 1`
`29`	`30`	`}`
`30`	`31`	`else`
`31`	`32`	`{`
Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,10 @@ public async Task TestConcurrentExchangeDeclareAndBind()`
`51`	`51`	`{`
`52`	`52`	`var exchangeNames = new ConcurrentBag<string>();`
`53`	`53`	`var tasks = new List<Task>();`
	`54`	`+`
	`55`	`+ string ex_destination = GenerateExchangeName();`
	`56`	`+ await _channel.ExchangeDeclareAsync(exchange: ex_destination, type: "fanout", false, false);`
	`57`	`+`
`54`	`58`	`NotSupportedException nse = null;`
`55`	`59`	`for (int i = 0; i < 256; i++)`
`56`	`60`	`{`
`@@ -61,7 +65,7 @@ async Task f()`
`61`	`65`	`await Task.Delay(S_Random.Next(5, 50));`
`62`	`66`	`string exchangeName = GenerateExchangeName();`
`63`	`67`	`await _channel.ExchangeDeclareAsync(exchange: exchangeName, type: "fanout", false, false);`
`64`		`- await _channel.ExchangeBindAsync(destination: "amq.fanout", source: exchangeName, routingKey: "unused");`
	`68`	`+ await _channel.ExchangeBindAsync(destination: ex_destination, source: exchangeName, routingKey: "unused");`
`65`	`69`	`exchangeNames.Add(exchangeName);`
`66`	`70`	`}`
`67`	`71`	`catch (NotSupportedException e)`
`@@ -84,7 +88,7 @@ async Task f()`
`84`	`88`	`try`
`85`	`89`	`{`
`86`	`90`	`await Task.Delay(S_Random.Next(5, 50));`
`87`		`- await _channel.ExchangeUnbindAsync(destination: "amq.fanout", source: exchangeName, routingKey: "unused",`
	`91`	`+ await _channel.ExchangeUnbindAsync(destination: ex_destination, source: exchangeName, routingKey: "unused",`
`88`	`92`	`noWait: false, arguments: null);`
`89`	`93`	`await _channel.ExchangeDeleteAsync(exchange: exchangeName, ifUnused: false);`
`90`	`94`	`}`
`@@ -99,6 +103,7 @@ await _channel.ExchangeUnbindAsync(destination: "amq.fanout", source: exchangeNa`
`99`	`103`
`100`	`104`	`await AssertRanToCompletion(tasks);`
`101`	`105`	`Assert.Null(nse);`
	`106`	`+ await _channel.ExchangeDeleteAsync(exchange: ex_destination);`
`102`	`107`	`}`
`103`	`108`
`104`	`109`	`[Fact]`