Make #amqqueue{} a private record

See the corresponding commit in rabbitmq-server for all the
explanations.

Now, all accesses to the #amqqueue{} record are made through the
`amqqueue` module (available in rabbitmq-server). The new type name is
`amqqueue:amqqueue()`.

The `amqqueue.hrl` header also provides some macros to help with pattern
matching and guard expressions.

To help with this, code and modules were moved from rabbitmq-common to
rabbitmq-server.

[#159298729]

Author: dumbbell

include/rabbit.hrl

@@ -11,9 +11,11 @@
 %% The Original Code is RabbitMQ.
 %%
 %% The Initial Developer of the Original Code is Pivotal Software, Inc.
-%% Copyright (c) 2007-2017 Pivotal Software, Inc.  All rights reserved.
+%% Copyright (c) 2007-2018 Pivotal Software, Inc.  All rights reserved.
 %%
 
+-include("resource.hrl").
+
 %% Passed around most places
 -record(user, {username,
                tags,
@@ -111,14 +113,6 @@
          payload_fragments_rev %% list of binaries, in reverse order (!)
          }).
 
--record(resource, {
-    virtual_host,
-    %% exchange, queue, ...
-    kind,
-    %% name as a binary
-    name
-}).
-
 %% fields described as 'transient' here are cleared when writing to
 %% rabbit_durable_<thing>
 -record(exchange, {
@@ -129,24 +123,6 @@
           decorators,
           options = #{}}).    %% transient, recalculated in store/1 (i.e. recovery)
 
--record(amqqueue, {
-          name, durable, auto_delete, exclusive_owner = none, %% immutable
-          arguments,                   %% immutable
-          pid,                         %% durable (just so we know home node)
-          slave_pids, sync_slave_pids, %% transient
-          recoverable_slaves,          %% durable
-          policy,                      %% durable, implicit update as above
-          operator_policy,             %% durable, implicit update as above
-          gm_pids,                     %% transient
-          decorators,                  %% transient, recalculated as above
-          state,                       %% durable (have we crashed?)
-          policy_version,
-          slave_pids_pending_shutdown,
-          vhost,                       %% secondary index
-          options = #{},
-          type = classic,
-          quorum_nodes }).
-
 -record(exchange_serial, {name, next}).
 
 %% mnesia doesn't like unary records, so we add a dummy 'value' field

include/resource.hrl

@@ -0,0 +1,23 @@
+%% The contents of this file are subject to the Mozilla Public License
+%% Version 1.1 (the "License"); you may not use this file except in
+%% compliance with the License. You may obtain a copy of the License
+%% at http://www.mozilla.org/MPL/
+%%
+%% Software distributed under the License is distributed on an "AS IS"
+%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
+%% the License for the specific language governing rights and
+%% limitations under the License.
+%%
+%% The Original Code is RabbitMQ.
+%%
+%% The Initial Developer of the Original Code is Pivotal Software, Inc.
+%% Copyright (c) 2007-2018 Pivotal Software, Inc.  All rights reserved.
+%%
+
+-record(resource, {
+    virtual_host,
+    %% exchange, queue, ...
+    kind,
+    %% name as a binary
+    name
+}).

src/rabbit_backing_queue.erl

@@ -29,7 +29,6 @@
 -export([method_record_type/1, polite_pause/0, polite_pause/1]).
 -export([die/1, frame_error/2, amqp_error/4, quit/1,
          protocol_error/3, protocol_error/4, protocol_error/1]).
--export([not_found/1, absent/2]).
 -export([type_class/1, assert_args_equivalence/4, assert_field_equivalence/4]).
 -export([dirty_read/1]).
 -export([table_lookup/2, set_table_value/4]).
@@ -129,9 +128,6 @@
             channel_or_connection_exit().
 -spec protocol_error(rabbit_types:amqp_error()) ->
           channel_or_connection_exit().
--spec not_found(rabbit_types:r(atom())) -> rabbit_types:channel_exit().
--spec absent(rabbit_types:amqqueue(), rabbit_amqqueue:absent_reason()) ->
-          rabbit_types:channel_exit().
 -spec type_class(rabbit_framing:amqp_field_type()) -> atom().
 -spec assert_args_equivalence
         (rabbit_framing:amqp_table(), rabbit_framing:amqp_table(),
@@ -303,29 +299,6 @@ protocol_error(Name, ExplanationFormat, Params, Method) ->
 protocol_error(#amqp_error{} = Error) ->
     exit(Error).
 
-not_found(R) -> protocol_error(not_found, "no ~s", [rs(R)]).
-
-absent(#amqqueue{name = QueueName, pid = QPid, durable = true}, nodedown) ->
-    %% The assertion of durability is mainly there because we mention
-    %% durability in the error message. That way we will hopefully
-    %% notice if at some future point our logic changes s.t. we get
-    %% here with non-durable queues.
-    protocol_error(not_found,
-                   "home node '~s' of durable ~s is down or inaccessible",
-                   [node(QPid), rs(QueueName)]);
-
-absent(#amqqueue{name = QueueName}, stopped) ->
-    protocol_error(not_found,
-                   "~s process is stopped by supervisor", [rs(QueueName)]);
-
-absent(#amqqueue{name = QueueName}, crashed) ->
-    protocol_error(not_found,
-                   "~s has crashed and failed to restart", [rs(QueueName)]);
-
-absent(#amqqueue{name = QueueName}, timeout) ->
-    protocol_error(not_found,
-                   "failed to perform operation on ~s due to timeout", [rs(QueueName)]).
-
 type_class(byte)          -> int;
 type_class(short)         -> int;
 type_class(signedint)     -> int;