New connection churn metrics table

Rate metrics for monitoring of high connection churn scenarios
[#160943831]

Author: dcorbacho

include/rabbit_core_metrics.hrl

@@ -30,10 +30,13 @@
                       {node_persister_metrics, set},
                       {node_coarse_metrics, set},
                       {node_metrics, set},
-                      {node_node_metrics, set}]).
+                      {node_node_metrics, set},
+                      {connection_churn_metrics, set}]).
 
 -define(CORE_EXTRA_TABLES, [{gen_server2_metrics, set}]).
 
+-define(CONNECTION_CHURN_METRICS, {node(), 0, 0, 0, 0, 0, 0, 0}).
+
 %% connection_created :: {connection_id, proplist}
 %% connection_metrics :: {connection_id, proplist}
 %% connection_coarse_metrics :: {connection_id, recv_oct, send_oct, reductions}
@@ -53,3 +56,4 @@
 %% node_metrics :: {node_id, proplist}
 %% node_node_metrics :: {{node_id, node_id}, proplist}
 %% gen_server2_metrics :: {pid, buffer_length}
+%% connection_churn_metrics :: {node(), connection_created, connection_closed, channel_created, channel_closed, queue_declared, queue_created, queue_deleted}

src/rabbit_core_metrics.erl

@@ -40,6 +40,8 @@
 
 -export([queue_stats/2,
          queue_stats/5,
+         queue_declared/1,
+         queue_created/1,
          queue_deleted/1,
          queues_deleted/1]).
 
@@ -113,13 +115,17 @@ terminate() ->
 
 connection_created(Pid, Infos) ->
     ets:insert(connection_created, {Pid, Infos}),
+    ets:update_counter(connection_churn_metrics, node(), {2, 1},
+                       ?CONNECTION_CHURN_METRICS),
     ok.
 
 connection_closed(Pid) ->
     ets:delete(connection_created, Pid),
     ets:delete(connection_metrics, Pid),
     %% Delete marker
     ets:update_element(connection_coarse_metrics, Pid, {5, 1}),
+    ets:update_counter(connection_churn_metrics, node(), {3, 1},
+                       ?CONNECTION_CHURN_METRICS),
     ok.
 
 connection_stats(Pid, Infos) ->
@@ -133,12 +139,16 @@ connection_stats(Pid, Recv_oct, Send_oct, Reductions) ->
 
 channel_created(Pid, Infos) ->
     ets:insert(channel_created, {Pid, Infos}),
+    ets:update_counter(connection_churn_metrics, node(), {4, 1},
+                       ?CONNECTION_CHURN_METRICS),
     ok.
 
 channel_closed(Pid) ->
     ets:delete(channel_created, Pid),
     ets:delete(channel_metrics, Pid),
     ets:delete(channel_process_metrics, Pid),
+    ets:update_counter(connection_churn_metrics, node(), {5, 1},
+                       ?CONNECTION_CHURN_METRICS),
     ok.
 
 channel_stats(Pid, Infos) ->
@@ -233,8 +243,22 @@ queue_stats(Name, MessagesReady, MessagesUnacknowledge, Messages, Reductions) ->
                                       Messages, Reductions}),
     ok.
 
+queue_declared(_Name) ->
+    %% Name is not needed, but might be useful in the future.
+    ets:update_counter(connection_churn_metrics, node(), {6, 1},
+                       ?CONNECTION_CHURN_METRICS),
+    ok.
+
+queue_created(_Name) ->
+    %% Name is not needed, but might be useful in the future.
+    ets:update_counter(connection_churn_metrics, node(), {7, 1},
+                       ?CONNECTION_CHURN_METRICS),
+    ok.
+
 queue_deleted(Name) ->
     ets:delete(queue_coarse_metrics, Name),
+    ets:update_counter(connection_churn_metrics, node(), {8, 1},
+                       ?CONNECTION_CHURN_METRICS),
     %% Delete markers
     ets:update_element(queue_metrics, Name, {3, 1}),
     CQX = ets:select(channel_queue_exchange_metrics, match_spec_cqx(Name)),