Use ETS operations that are available in Erlang 19.3

ets:select_replace/2 is only available in Erlang 20 and above. RabbitMQ
3.7 needs to support Erlang 19.3 and above.

We haven't noticed any difference in performance when using one approach
over the other.

To keep the code simple, we decided to not detect which approach to use.

Partern-in-crime: @essen

Author: gerhard

src/rabbit_core_metrics.erl

@@ -265,28 +265,34 @@ delete_queue_metrics(Queue) ->
     ok.
 
 delete_channel_queue_exchange_metrics(MatchSpecCondition) ->
-    ets:select_replace(
+    ChannelQueueExchangeMetricsToUpdate = ets:select(
         channel_queue_exchange_metrics,
         [
             {
-                {{'$2', {'$1', '$3'}}, '$4', '_'},
+                {{'$2', {'$1', '$3'}}, '_', '_'},
                 [MatchSpecCondition],
-                [{{{{'$2', {{'$1', '$3'}}}}, '$4', 1}}]
+                [{{'$2', {{'$1', '$3'}}}}]
             }
         ]
-    ).
+    ),
+    lists:foreach(fun(Key) ->
+        ets:update_element(channel_queue_exchange_metrics, Key, {3, 1})
+    end, ChannelQueueExchangeMetricsToUpdate).
 
 delete_channel_queue_metrics(MatchSpecCondition) ->
-    ets:select_replace(
+    ChannelQueueMetricsToUpdate = ets:select(
         channel_queue_metrics,
         [
             {
-                {{'$2', '$1'}, '$3', '$4', '$5', '$6', '$7', '$8', '_'},
+                {{'$2', '$1'}, '_', '_', '_', '_', '_', '_', '_'},
                 [MatchSpecCondition],
-                [{{{{'$2', '$1'}}, '$3', '$4', '$5', '$6', '$7', '$8', 1}}]
+                [{{'$2', '$1'}}]
             }
         ]
-    ).
+    ),
+    lists:foreach(fun(Key) ->
+        ets:update_element(channel_queue_metrics, Key, {8, 1})
+    end, ChannelQueueMetricsToUpdate).
 
 % [{'orelse',
 %    {'==', {Queue}, '$1'},