feat(popover): Signing cla

Author: Zankel-Engineering

apps/website/src/routes/docs/headless/(components)/popover/examples.tsx

@@ -1,6 +1,5 @@
 import { Slot, component$ } from '@builder.io/qwik';
 import { Popover, PopoverContent, PopoverTrigger } from '@qwik-ui/headless';
-import { GitHubIcon } from 'apps/website/src/components/icons/GitHubIcon';
 import { PreviewCodeExample } from 'apps/website/src/components/preview-code-example/preview-code-example';
 
 export const MainExample = component$(() => {
@@ -11,7 +10,9 @@ export const MainExample = component$(() => {
           <PopoverContent>
             <div class="p-4 bg-gray-500">Hi, I'm the content</div>
           </PopoverContent>
-          <PopoverTrigger> Click on me </PopoverTrigger>
+          <PopoverTrigger ariaAttributes={{ ariaLabel: 'click-friend' }}>
+            Click on me
+          </PopoverTrigger>
         </Popover>
       </div>
       <div q:slot="codeExample">
@@ -31,7 +32,9 @@ export const Example1 = component$(() => {
               Hi, I'm the content, but now on top
             </div>
           </PopoverContent>
-          <PopoverTrigger> Click on me </PopoverTrigger>
+          <PopoverTrigger ariaAttributes={{ ariaLabel: 'no-click-friend' }}>
+            Click on me
+          </PopoverTrigger>
         </Popover>
       </div>
       <div q:slot="codeExample">

cla-signs/v1/cla.json

@@ -287,6 +287,14 @@
       "created_at": "2023-06-17T13:56:24Z",
       "repoId": 545159943,
       "pullRequestNo": 340
+    },
+    {
+      "name": "Zankel-Engineering",
+      "id": 43412711,
+      "comment_id": 1802088836,
+      "created_at": "2023-07-15T17:00:00Z",
+      "repoId": 666652720,
+      "pullRequestNo": 363
     }
   ]
-}
+}

packages/kit-headless/src/utils/aria-attributes-helper.ts

@@ -20,33 +20,26 @@ type FunctionType = (
   ariaAttributes?: Partial<QwikUiAriaAttributesKebab>
 ) => Partial<AriaAttributes>;
 
+const cacheMap: Map<string, Partial<AriaAttributes>> = new Map();
+
+const memoize = (func: FunctionType): FunctionType => {
+  return (
+    ariaAttributes?: Partial<QwikUiAriaAttributesKebab>
+  ): Partial<AriaAttributes> => {
+    const key = JSON.stringify(ariaAttributes);
+    if (!cacheMap.has(key) || !ariaAttributes) {
+      const out = func(ariaAttributes);
+      cacheMap.set(key, out);
+      return out;
+    } else {
+      return cacheMap.get(key) || {};
+    }
+  };
+};
+
 export const useAriaAttributes = (
   ariaAttributes?: Partial<QwikUiAriaAttributesKebab>
 ): Partial<AriaAttributes> => {
-  const memoize = (func: FunctionType): FunctionType => {
-    let cache:
-      | { in: string | undefined; out: Partial<AriaAttributes> }
-      | undefined;
-    return (
-      ariaAttributes?: Partial<QwikUiAriaAttributesKebab>
-    ): Partial<AriaAttributes> => {
-      if (!cache || !ariaAttributes) {
-        const out = func(ariaAttributes);
-        cache = {
-          in: ariaAttributes ? JSON.stringify(ariaAttributes) : undefined,
-          out,
-        };
-        return out;
-      } else {
-        const newCacheInValue = JSON.stringify(ariaAttributes);
-        if (cache.in === newCacheInValue) {
-          return cache.out;
-        }
-        cache = { in: newCacheInValue, out: func(ariaAttributes) };
-        return cache.out;
-      }
-    };
-  };
   const process = (
     ariaAttributes?: Partial<QwikUiAriaAttributesKebab>
   ): Partial<AriaAttributes> => {