fix(qwik-nx): preset generator should check for the presense of peerDeps #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-stepanenko
force-pushed
the
ds/fix-package-install
branch
from
58eae92 to
d441f1c
Compare
reemardelarosa
pushed a commit
to reemardelarosa/qwik-nx
that referenced
this pull request
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
When repository is created, peer dependencies are not installed by default. Because of this
@nrwl/viteis not available and an error is thrown.Along with this checking for the installed nx version should be improved: it's not enough to check for the presence of
@nrwl/workspacein devDependenciescloses #89
Use cases and why
Screenshots/Demo
Checklist: