feat(qwik-nx): use @nrwl/vite:preview-server executor #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-stepanenko
force-pushed
the
ds/new-preview-executor
branch
from
d7d3fdf to
408819a
Compare
|
LGTM! thanks ! Can you please resolve the merge conflicts and merge this PR? thanks 🙏 |
dmitry-stepanenko
force-pushed
the
ds/new-preview-executor
branch
from
408819a to
5c487e7
Compare
reemardelarosa
pushed a commit
to reemardelarosa/qwik-nx
that referenced
this pull request
Mar 9, 2023
* feat: use [email protected] * fix(qwik-nx): do not yield intermediate build results * feat(qwik-nx): use @nrwl/vite:preview-server executor * test: add snapshot for app generator unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Switching to the
@nrwl/vite:preview-serverexecutor to have consistent behavior and rely on nrwl tooling as much as possible.