feat(qwik-nx): build executor #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-stepanenko
force-pushed
the
ds/build-executor
branch
7 times, most recently
from
4c834cd to
05e67d6
Compare
|
LGTM Great and thorough job @dmitry-stepanenko ! 👏🙏 |
dmitry-stepanenko
force-pushed
the
ds/build-executor
branch
from
7116526 to
63d6f94
Compare
dmitry-stepanenko
force-pushed
the
ds/build-executor
branch
2 times, most recently
from
6e58e0b to
655262e
Compare
dmitry-stepanenko
force-pushed
the
ds/build-executor
branch
from
655262e to
8de47ab
Compare
reemardelarosa
pushed a commit
to reemardelarosa/qwik-nx
that referenced
this pull request
Mar 9, 2023
* feat(qwik-nx): build executor * feat(qwik-nx): build executor migration and test coverage * feat(qwik-nx): update target & configuration names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Adding a new build executor, that will unify the flow to build the Qwik project in a similar way how it's done with original qwik apps with Qwik CLI.
The new executor wraps
build.clientandbuild.ssrtargets intobuildexecutor, where they can both be executed sequentially. It also allows to projectbuild's target configuration to the ones it invokes.With this change the commands will be as follows:
Along with breaking changes this PR presents there's a NX migration available, that should help updating the config. It can be used by running
nx migrate qwik-nxcommand