Skip to content

Conversation

dmitry-stepanenko
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

  1. when running npx create-nx-workspace somename --preset-qwik-nx, qwik-nx:preset generator uses default argument somename for the application name, while it is supposed to only be used for the workspace name
  2. @nrwl/js:tsc executor builds qwik-nx package and includes dependencies of dependencies in its package.json. SInce this is happening, we should at least specify wider range of dependencies in order to not limit users to a single strict version

@shairez shairez merged commit 1eebff7 into main Feb 8, 2023
@shairez shairez deleted the ds/fix-preset branch February 8, 2023 12:12
reemardelarosa pushed a commit to reemardelarosa/qwik-nx that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants