Skip to content

Conversation

wtlin1228
Copy link
Contributor

@wtlin1228 wtlin1228 commented Apr 26, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

useLocation() returns us a RouteLocation instance. So we should get the href from loc.url.href.

export declare interface RouteLocation {
    readonly params: Readonly<Record<string, string>>;
    readonly url: URL;
    readonly isNavigating: boolean;
}

Use cases and why

    1. Generate qwik application by running nx generate qwik-nx:application
    1. Another use case

Screenshots/Demo

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@nx-cloud
Copy link

nx-cloud bot commented Apr 26, 2023

@dmitry-stepanenko
Copy link
Contributor

Thanks for catching this!

@dmitry-stepanenko dmitry-stepanenko merged commit d82dad4 into qwikifiers:main Apr 26, 2023
reemardelarosa pushed a commit to reemardelarosa/qwik-nx that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants