feat(qwik-nx): move peer dependencies to dependencies #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-stepanenko
force-pushed
the
ds/move-peer-deps-to-deps
branch
from
e458236 to
b4d3fbb
Compare
7 tasks
reemardelarosa
pushed a commit
to reemardelarosa/qwik-nx
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
@nrwl/*packages that are specified as peer dependencies ofqwik-nxpackage are crucial to execute any of the package's generators, thus it makes much more sense to keep them asdependenciesinstead. By addingupdateBuildableProjectDepsInPackageJsonproperty to project's build target it is possible to make nx executor to not override versions (as it was before).