Normale Validation-Attribute benutzen #185
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the attempt ui lives in an iframe now, the normal validation attributes won't prevent submission. See: questionpy-org/moodle-qtype_questionpy@ebaed00
Since it tests the legacy renderer.
janbritz
approved these changes
May 26, 2025
tumidi
requested changes
May 26, 2025
There was a problem hiding this comment.
Ohh... das war ein Fehler meinerseits. tests/questionpy_sdk/webserver/controllers/attempt/test_question_ui.py darf nicht von webserver_legacy importieren, sondern von webserver:
test_question_ui.py, sowie auch test_data verbleiben wo sie sind, nur die Imports in test_question_ui.py müssten angepasst werden:
from questionpy_sdk.webserver.controllers.attempt.errors import (
ConversionError,
DuplicateNameError,
ExpectedAncestorError,
InvalidAttributeValueError,
InvalidCleanOptionError,
InvalidContentError,
PlaceholderReferenceError,
RenderError,
UnknownAttributeError,
UnknownElementError,
XMLSyntaxError,
)
from questionpy_sdk.webserver.controllers.attempt.question_ui import (
DisplayRole,
QuestionDisplayOptions,
QuestionFormulationUIRenderer,
QuestionMetadata,
QuestionUIRenderer,
)Aktuell ist der QuestionUIRenderer-Code dupliziert in
questionpy_sdk.webserver.controllers.attempt.question_ui(neu), sowiequestionpy_sdk.webserver_legacy.question_ui(alt, fliegt bald raus)
| --text-color: black; | ||
|
|
||
| :is(input, select, textarea):invalid { | ||
| border-color: var(--invalid-input-color); |
There was a problem hiding this comment.
Anders als im questionpy-org/moodle-qtype_questionpy#184 verwendet das Attempt-Ui im SDK noch kein Bootstrap.
Ja, richtig, hier könnten wir zukünftig auch Bootstrap importieren oder so. Aktuell propagiere ich nur color theme ins iframe für eine zukünftige Bootstrap-Unterstützung.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anders als im Plugin verwendet das Attempt-Ui im SDK noch kein Bootstrap. Das wollte ich nicht mal eben so ändern, ohne mit @tumidi zu sprechen, daher ist die "Implementierung" hier erstmal trivial, invalide Elemente werden einfach rot umrandet. Die validation message zeigt der Browser ohnehin beim drüberhovern an.
Wir sollten der Frage mittelfristig noch irgendeine Art von Styling verpassen, das können wir dann ja in 2 Wochen besprechen ;)
Closes: #184