Skip to content

[docs] changing examples to the trades dataset #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 14, 2024
Merged

Conversation

javier
Copy link
Contributor

@javier javier commented Jul 19, 2024

Changed examples to use the trades dataset. Examples are now consistent with the QuestDB docs

@javier javier added the documentation Improvements or additions to documentation label Jul 19, 2024
@amunra
Copy link
Collaborator

amunra commented Jul 22, 2024

Test failures seem to be related to changes in the Pandas API in regards to the error messages.

Copy link
Contributor

@nwoolmer nwoolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its passed, don't jinx it!

@ideoma ideoma merged commit d0bc7a3 into main Aug 14, 2024
1 check passed
@ideoma ideoma deleted the jv/example-update branch August 14, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants