Skip to content

feat: Accept None as column values in Buffer.row() API. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

amunra
Copy link
Collaborator

@amunra amunra commented Aug 1, 2022

Enhancing the Buffer.row(.., columns={...}) API to accept None values.

This will write NULL entries (by skipping the column in ILP) when such column already exists.

Providing a column with a None value is semantically equivalent to not providing the column at all and is offered as a convenience.

Closes #3 and #4.

@amunra amunra requested a review from marregui August 1, 2022 16:19
Copy link
Contributor

@marregui marregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amunra amunra merged commit 9d7ef9b into main Aug 3, 2022
@amunra amunra deleted the none_arg_in_row branch August 5, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sender.row() should allow insertion of NULL values using python None value
2 participants