Skip to content

Added QCS6490 support for Watchdog test #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added QCS6490 support for Watchdog test #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Runner/suites/Kernel/FunctionalArea/baseport/watchdog/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,13 @@ if [ -e /dev/watchdog ]; then
log_pass "$TESTNAME : Test Passed"
echo "$TESTNAME PASS" > "$res_file"
else
log_fail "/dev/watchdog node is not present."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if /dev/watchdog is missing, test could still pass if the kernel configs are correct. But ideally.

  • Validate presence of a watchdog driver (eg: module loaded or DT node)

log_fail "$TESTNAME : Test Failed"
echo "$TESTNAME FAIL" > "$res_file"
CONFIGS="CONFIG_WATCHDOG CONFIG_ARM_SMC_WATCHDOG CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED"
check_kernel_config "$CONFIGS" || {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better check for non-zero with condition for better debuggin in CI.
if [ $? -ne 0 ]; then log_fail "$TESTNAME : Required kernel configs missing" echo "$TESTNAME FAIL" > "$res_file" exit 1 fi

log_fail "$TESTNAME FAIL"
echo "$TESTNAME FAIL" > "$res_file"
exit 1
}
log_pass "$TESTNAME : Test Passed"
echo "$TESTNAME PASS" > "$res_file"
fi
log_info "-------------------Completed $TESTNAME Testcase---------------------------"
Loading