Add support for Python 3.12 #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a little overlap with #1351 where I also addressed the datetime warning. |
|
@wshanks Ahh right, my bad, your fix is simpler so I've switched to yours. |
wshanks
approved these changes
Jan 19, 2024
|
@coruscating We have confused GitHub here. The merge queue is blocked waiting for the 3.11 tests but this PR replaces them with 3.12 tests so they will never run. Maybe you can override and merge this with your admin privileges? I hope this doesn't foul up the other pre-existing PRs with 3.11 runs. |
|
@wshanks Thanks for catching the cron job config! This PR merged fine after I changed the branch protection rules to look for passing 3.12 tests instead of 3.11, and existing open PRs just have to merge the changes from main and rerun their CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that Aer supports Python 3.12 starting with 0.13.2 (Qiskit/qiskit-aer#2022), we should be able to support it as well. The only code change needed was to update the deprecated usage of
datetime.datetime.utcnow()todatetime.datetime.now(datetime.UTC). I added a python version checker to handle this sincedatetime.UTCwas only introduced in 3.11.