-
Notifications
You must be signed in to change notification settings - Fork 68
Add Python 3.12 support #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This works with Ubuntu and Mac, but not Windows, where the cause is Aer not yet supporting 3.12 In Ubuntu and Mac it manages to build the wheels from source, so things pass there. Not so in Windows. I think the only dependence here for Aer is just in the tutorials right with the one that shows VQE with simulation under a noise model. |
I put this OnHold for now. We could drop the max level for Win to 3.11 in CI or wait until Aer supports 3.12 and wheels are released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that limiting the CI Python version for Win to 3.11 in CI sounds reasonable given the current release timeline of Aer. There is a good amount of interest in Python 3.12 being supported in Qiskit in general and I think it would be nice to start running CI on it on some platforms.
Pull Request Test Coverage Report for Build 7104980234
💛 - Coveralls |
Ok, I dropped the Win CI upper bound down to 3.11 and raised #109 to serve as a reminder to put it back to 3.12 once Aer releases wheels. So it just needs the branch rules updating so as all new CI runs are required (Algorithms Ubuntu, Algorithms Mac and Tutorials for 3.12) and the couple of 3.11 ones that no longer run are set not required any more. |
I updated the main branch rules for the jobs as they now stand from this PR. |
Summary
Given Qiskit 0.45.1 just released with Python 3.12 support I have added that here to Algorithms.
Details and comments
I added a new Ubuntu 3.12 run so that OS spans all the versions. I changed Mac and Windows to 3.12 from 3.11 so it tests the min and max versions supported now (just as it did before when 3.11 was the max). I did the same for Qiskit Main monitoring.
FYI I do not have 3.12 locally at present to check things so we'll see how it goes here...