Skip to content

Add Python 3.12 support #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented Nov 29, 2023

Summary

Given Qiskit 0.45.1 just released with Python 3.12 support I have added that here to Algorithms.

Details and comments

I added a new Ubuntu 3.12 run so that OS spans all the versions. I changed Mac and Windows to 3.12 from 3.11 so it tests the min and max versions supported now (just as it did before when 3.11 was the max). I did the same for Qiskit Main monitoring.

FYI I do not have 3.12 locally at present to check things so we'll see how it goes here...

  • This will of course need the branch protection rules changing.

@woodsp-ibm
Copy link
Member Author

This works with Ubuntu and Mac, but not Windows, where the cause is Aer not yet supporting 3.12 In Ubuntu and Mac it manages to build the wheels from source, so things pass there. Not so in Windows. I think the only dependence here for Aer is just in the tutorials right with the one that shows VQE with simulation under a noise model.

@woodsp-ibm woodsp-ibm added the on hold Can not fix yet label Nov 29, 2023
@woodsp-ibm
Copy link
Member Author

woodsp-ibm commented Nov 29, 2023

I put this OnHold for now. We could drop the max level for Win to 3.11 in CI or wait until Aer supports 3.12 and wheels are released.

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that limiting the CI Python version for Win to 3.11 in CI sounds reasonable given the current release timeline of Aer. There is a good amount of interest in Python 3.12 being supported in Qiskit in general and I think it would be nice to start running CI on it on some platforms.

@coveralls
Copy link

coveralls commented Dec 1, 2023

Pull Request Test Coverage Report for Build 7104980234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.578%

Totals Coverage Status
Change from base Build 7104583722: 0.0%
Covered Lines: 6470
Relevant Lines: 7143

💛 - Coveralls

@woodsp-ibm
Copy link
Member Author

woodsp-ibm commented Dec 1, 2023

Ok, I dropped the Win CI upper bound down to 3.11 and raised #109 to serve as a reminder to put it back to 3.12 once Aer releases wheels. So it just needs the branch rules updating so as all new CI runs are required (Algorithms Ubuntu, Algorithms Mac and Tutorials for 3.12) and the couple of 3.11 ones that no longer run are set not required any more.

@woodsp-ibm woodsp-ibm removed the on hold Can not fix yet label Dec 1, 2023
@ElePT ElePT added the automerge label Dec 4, 2023
@woodsp-ibm
Copy link
Member Author

I updated the main branch rules for the jobs as they now stand from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants