Skip to content

Commit ac2de09

Browse files
authored
AFP-244: Only display pagination if there is more than one page (#35)
* AFP-244: Only display pagination if there is more than one page * AFP-244: Added unit test
1 parent ea61c4b commit ac2de09

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

packages/react-changelogs/src/__tests__/changelog.test.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,15 @@ describe('<Changelog />', () => {
100100
expect(wrapper.find(Pagination).find('button')).toHaveLength(8);
101101
});
102102

103+
it('should not paginate if there is only one page', () => {
104+
const wrapper = mount(
105+
<Changelog changelog={initialProps} entriesPerPage={20} />,
106+
);
107+
108+
expect(wrapper.find('h3')).toHaveLength(2);
109+
expect(wrapper.find(Pagination).exists()).toEqual(false);
110+
});
111+
103112
it('should not paginate if entriesPerPage is null', () => {
104113
const wrapper = mount(
105114
<Changelog changelog={longChangeLog} entriesPerPage={null} />,

packages/react-changelogs/src/components/changelog.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export default class Changelog extends React.Component<Props> {
169169
);
170170
})
171171
)}
172-
{entriesPerPage && (
172+
{entriesPerPage && pages.length > 1 && (
173173
<PaginationContainer>
174174
<Pagination pages={pages} onChange={this.handlePageChange} />
175175
</PaginationContainer>

0 commit comments

Comments
 (0)