make type alias private #7266
Merged
make type alias private #7266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Feb 16, 2023
Comment on lines
+2
to
+5
| from ._datapoint import _FillType, _FillTypeJIT, _InputType, _InputTypeJIT | ||
| from ._image import _ImageType, _ImageTypeJIT, _TensorImageType, _TensorImageTypeJIT, Image | ||
| from ._mask import Mask | ||
| from ._video import TensorVideoType, TensorVideoTypeJIT, Video, VideoType, VideoTypeJIT | ||
| from ._video import _TensorVideoType, _TensorVideoTypeJIT, _VideoType, _VideoTypeJIT, Video |
There was a problem hiding this comment.
This is the change with the smallest diff. We could also remove them from this namespace completely and just import from the respective module directly where we need them. If we do that, should we still prefix them with an underscore? Just removing them here would also mark them private, since the module there are defined in is private as well.
|
Do you see any harm of exposing them as public types ? |
Yes. If we make them public, we need to keep BC. Meaning if something changes, for example #7252 we have to work around that. |
|
OK, why not, but those are just types and we are not exposing py.typed so there is little chances they are used, IMO |
NicolasHug
approved these changes
Feb 16, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
Reviewed By: vmoens Differential Revision: D44416583 fbshipit-source-id: 33f61d6cae4f1ac19b68376b8982069135353eef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since they are just used internally, there is no need to have them public.
cc @vfdev-5 @bjuncek