Skip to content

perform out of bounds check for single values and two tuples in ColorJitter #7133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2023
Merged

perform out of bounds check for single values and two tuples in ColorJitter #7133

merged 4 commits into from
Jan 26, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jan 26, 2023 •
edited by pytorch-bot bot
Loading

Closes #7132.

cc @vfdev-5

NicolasHug
NicolasHug approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, some nits but LGTM anyway.

As an extra NIT: do we want to / should we raise and error if a tuple is passed while center has a non-default value? Does it matter?

@pmeier pmeier merged commit 59dc938 into pytorch:main Jan 26, 2023
@pmeier pmeier deleted the color-jitter-bounds branch January 26, 2023 14:49
facebook-github-bot pushed a commit that referenced this pull request Feb 8, 2023
@NicolasHug @facebook-github-bot
[fbsync] perform out of bounds check for single values and two tuples…
de6c212 
… in ColorJitter (#7133)

Reviewed By: vmoens

Differential Revision: D43116120

fbshipit-source-id: f2a73099f2246862d157d3aef6b7b03ceebfaf82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ColorJitter doesn't check bounds for single value inputs
3 participants
@pmeier @NicolasHug @facebook-github-bot