Skip to content

[Nova] Disable CircleCI Linux CPU Unittests #6968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

osalpekar
Copy link
Member

@osalpekar osalpekar commented Nov 21, 2022

Linux CPU and GPU Unittests have been running smoothly for several weeks, so going ahead and removing the CircleCI Linux Unittest jobs. If we see any issues or high queueing, we can bring this back.

cc @seemethere

@osalpekar osalpekar marked this pull request as ready for review November 21, 2022 22:16
@pmeier
Copy link
Collaborator

pmeier commented Nov 22, 2022

@osalpekar I don't think this is the case for GPU: #6957. Could you look into this first?

@NicolasHug, AFAIK we want to skip the CPU tests on GPU machines, right? I think we need to update

vision/test/conftest.py

Lines 15 to 24 in 4a310f2

def pytest_collection_modifyitems(items):
# This hook is called by pytest after it has collected the tests (google its name to check out its doc!)
# We can ignore some tests as we see fit here, or add marks, such as a skip mark.
#
# Typically here, we try to optimize CI time. In particular, the GPU CI instances don't need to run the
# tests that don't need CUDA, because those tests are extensively tested in the CPU CI instances already.
# This is true for both CircleCI and the fbcode internal CI.
# In the fbcode CI, we have an additional constraint: we try to avoid skipping tests. So instead of relying on
# pytest.mark.skip, in fbcode we literally just remove those tests from the `items` list, and it's as if
# these tests never existed.
to also account for GHA. Do you want to send a patch or shall I?

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osalpekar In #6970 I've confirmed that the GPU setup is incorrect and so far we have never run any CUDA tests on GHA. This needs to be addressed first. If you prefer, I'm also ok with moving this PR forward if we exclude the removal of the CUDA jobs.

@osalpekar
Copy link
Member Author

@pmeier Sounds good, I've added back the Linux GPU CI jobs here, so this PR only disabled Linux CPU unittests.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns regarding CPU unittests from my side. Thanks Omkar!

@osalpekar osalpekar changed the title [Nova] Disable CircleCI Linux Unittests [Nova] Disable CircleCI Linux CPU Unittests Nov 28, 2022
@osalpekar osalpekar merged commit b94f176 into pytorch:main Nov 30, 2022
@github-actions
Copy link

Hey @osalpekar!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Dec 1, 2022
Summary:
* [Nova] Disable CircleCI Linux Unittests

* add back linux gpu jobs

Reviewed By: YosuaMichael

Differential Revision: D41648539

fbshipit-source-id: d865e38327d5132392db3e87fd62f8b9790b0c5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants