-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[Nova] Disable CircleCI Linux CPU Unittests #6968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@osalpekar I don't think this is the case for GPU: #6957. Could you look into this first? @NicolasHug, AFAIK we want to skip the CPU tests on GPU machines, right? I think we need to update Lines 15 to 24 in 4a310f2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osalpekar In #6970 I've confirmed that the GPU setup is incorrect and so far we have never run any CUDA tests on GHA. This needs to be addressed first. If you prefer, I'm also ok with moving this PR forward if we exclude the removal of the CUDA jobs.
e86a622
to
bf9c2c7
Compare
@pmeier Sounds good, I've added back the Linux GPU CI jobs here, so this PR only disabled Linux CPU unittests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns regarding CPU unittests from my side. Thanks Omkar!
bf9c2c7
to
b7f24a0
Compare
b7f24a0
to
4342d84
Compare
Hey @osalpekar! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * [Nova] Disable CircleCI Linux Unittests * add back linux gpu jobs Reviewed By: YosuaMichael Differential Revision: D41648539 fbshipit-source-id: d865e38327d5132392db3e87fd62f8b9790b0c5a
Linux CPU and GPU Unittests have been running smoothly for several weeks, so going ahead and removing the CircleCI Linux Unittest jobs. If we see any issues or high queueing, we can bring this back.
cc @seemethere