[bugfix] Check if norm_layer has not-None weight before init #6082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YosuaMichael : Your bugfix looks reasonable to me. Small remark: Maybe for the user it would be good to also throw out a warning (if |
datumbox
approved these changes
May 25, 2022
There was a problem hiding this comment.
LGTM, thanks @YosuaMichael.
@FloCF Thanks for reporting the bug and for the recommendations. The implementation is generally expecting to receive a norm_layer compatible with the original architecture (BN, SyncBN, FrozenBN etc). I'm fine with fixing the breakage though.
YosuaMichael
added a commit
to YosuaMichael/vision
that referenced
this pull request
May 25, 2022
YosuaMichael
added a commit
that referenced
this pull request
May 25, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
…#6082) Reviewed By: NicolasHug Differential Revision: D36760938 fbshipit-source-id: 366bbd3fa225431dd5a0871019bb0e70d348ee7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to resolve bug reported on #6074.
@datumbox I may not have a full context here, let me know what you think.