Skip to content

[NOMRG] Install dill to test prototype datasets when dill is installed #5938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

NicolasHug
Copy link
Member

This PR installs dill for the prototype CIs.
Having dill installed in one's environement has shown to create (now fixed) issues in the past pytorch/pytorch#74984. I'm just creating this PR to make sure there are no additional problems. We shouldn't merge this PR (probably ever), but it's worth keeping it up to date from time to time.

CC @pmeier

@pmeier
Copy link
Collaborator

pmeier commented May 4, 2022

(now fixed)

Well, the tests are failing for now, but will hopefully pass after pytorch/pytorch#74984.

@ejguan @NivekT This is our hack to make sure just having dill in the environment does not break our datasets. I can't find the comment now, but IIRC you wanted to go for a manual serialization backend selection. If this is implemented, we could simply parametrize our tests instead. Is this tracked anywhere?

@NicolasHug NicolasHug marked this pull request as ready for review May 13, 2022 13:13
@NicolasHug NicolasHug marked this pull request as draft May 13, 2022 13:13
@NicolasHug NicolasHug closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants