-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Remove input checks for generalized_box_iou #5691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 2fb7450 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Job | Step | Action |
---|---|---|
packaging/build_cmake.sh | 🔁 rerun | |
curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh | ||
sh conda.sh -b | ||
source $HOME/miniconda3/bin/activate | ||
packaging/build_wheel.sh | ||
🔁 rerun | ||
set -ex | ||
source packaging/windows/internal/vc_install_helper.sh | ||
packaging/build_cmake.sh | ||
🔁 rerun | ||
packaging/build_conda.sh | 🔁 rerun | |
packaging/build_conda.sh | 🔁 rerun | |
curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh | ||
sh conda.sh -b | ||
source $HOME/miniconda3/bin/activate | ||
conda install -yq conda-build | ||
packaging/build_conda.sh | ||
🔁 rerun | ||
curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh | ||
sh conda.sh -b | ||
source $HOME/miniconda3/bin/activate | ||
conda install -yq conda-build cmake | ||
packaging/build_cmake.sh | ||
🔁 rerun | ||
packaging/build_conda.sh | 🔁 rerun |
🚧 5 ongoing upstream failures:
These were probably caused by upstream breakages that are not fixed yet.
- binary_win_conda_py3.10_cu115 since Mar 28 (818dc22)
- binary_linux_conda_py3.10_cpu since Mar 28 (b031e91)
- unittest_windows_cpu_py3.7 since Mar 28 (818dc22)
- cmake_windows_gpu since Mar 28 (818dc22)
- binary_linux_conda_py3.10_cu113 since Mar 28 (b031e91)
🚧 1 fixed upstream failure:
These were probably caused by upstream breakages that were already fixed.
Please rebase on the viable/strict
branch (expand for instructions)
If your commit is older than viable/strict
, run these commands:
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
- build_docs on Mar 28 from 4:14am to 7:13am (818dc22 - b031e91)
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. please merge once tests pass
The test fail due to Conda's HTTP 500 responses, which are not related to this PR. Mots of unit-tests pass normally so we should be OK, but I'll restart them to see if the problem is resolved. |
The only failing unit-test, is related to missing binaries. We should be good to merge. |
Summary: (Note: this ignores all push blocking failures!) Reviewed By: YosuaMichael Differential Revision: D35216795 fbshipit-source-id: e980727b4799e31bd4729aadf107f5d98307f6e5
Similar to #5322 and as discussed at #5684 (comment), we shouldn't put input checks in the box utility ops to avoid slow-downs due to GPU/CPU synchronisation.