Skip to content

Remove input checks for generalized_box_iou #5691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

datumbox
Copy link
Contributor

Similar to #5322 and as discussed at #5684 (comment), we shouldn't put input checks in the box utility ops to avoid slow-downs due to GPU/CPU synchronisation.

@facebook-github-bot
Copy link

facebook-github-bot commented Mar 28, 2022

💊 CI failures summary and remediations

As of commit 2fb7450 (more details on the Dr. CI page):



🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build unittest_windows_cpu_py3.8 (1/2)

Step: "Install torchvision" (full log | diagnosis details | 🔁 rerun)

A 500-type error (e.g. 500, 501, 502, 503, etc.) indicates the server failed to
+ export PATH
+ /c/Users/circleci/project/conda/Scripts/conda.exe install -y -c pytorch-nightly -c nvidia 'pytorch-nightly::pytorch[build=*cpu*]' cpuonly pytest
Collecting package metadata (current_repodata.json): ...working... failed

CondaHTTPError: HTTP 500 INTERNAL SERVER ERROR for url <https://conda.anaconda.org/nvidia/noarch/repodata.json>
Elapsed: 00:06.986092
CF-RAY: 6f30ef9ba8961010-ATL

A remote server error occurred when trying to retrieve this URL.

A 500-type error (e.g. 500, 501, 502, 503, etc.) indicates the server failed to
fulfill a valid request.  The problem may be spurious, and will resolve itself if you
try your request again.  If the problem persists, consider notifying the maintainer
of the remote server.


+ return


Exited with code exit status 1

See CircleCI build binary_macos_wheel_py3.7_cpu (2/2)

Step: "curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
packaging/build_wheel.sh
" (full log | diagnosis details | 🔁 rerun)

A 500-type error (e.g. 500, 501, 502, 503, etc.) indicates the server failed to
+ export PATH
+ /Users/distiller/miniconda3/bin/conda install -yq ffmpeg=4.2 -c pytorch
Collecting package metadata (current_repodata.json): ...working... failed

CondaHTTPError: HTTP 500 INTERNAL SERVER ERROR for url <https://conda.anaconda.org/pytorch/osx-64/repodata.json>
Elapsed: 00:06.533538
CF-RAY: 6f30f2c31d9a6386-ORD

A remote server error occurred when trying to retrieve this URL.

A 500-type error (e.g. 500, 501, 502, 503, etc.) indicates the server failed to
fulfill a valid request.  The problem may be spurious, and will resolve itself if you
try your request again.  If the problem persists, consider notifying the maintainer
of the remote server.


+ return


Exited with code exit status 1


8 failures not recognized by patterns:

Job Step Action
CircleCI cmake_linux_cpu packaging/build_cmake.sh 🔁 rerun
CircleCI binary_macos_wheel_py3.10_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
packaging/build_wheel.sh
🔁 rerun
CircleCI cmake_windows_cpu set -ex
source packaging/windows/internal/vc_install_helper.sh
packaging/build_cmake.sh
🔁 rerun
CircleCI binary_linux_conda_py3.8_cpu packaging/build_conda.sh 🔁 rerun
CircleCI binary_linux_conda_py3.10_cu102 packaging/build_conda.sh 🔁 rerun
CircleCI binary_macos_conda_py3.10_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build
packaging/build_conda.sh
🔁 rerun
CircleCI cmake_macos_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build cmake
packaging/build_cmake.sh
🔁 rerun
CircleCI binary_linux_conda_py3.9_cu115 packaging/build_conda.sh 🔁 rerun

🚧 5 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@jdsgomes jdsgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please merge once tests pass

@datumbox
Copy link
Contributor Author

The test fail due to Conda's HTTP 500 responses, which are not related to this PR. Mots of unit-tests pass normally so we should be OK, but I'll restart them to see if the problem is resolved.

@datumbox
Copy link
Contributor Author

The only failing unit-test, is related to missing binaries. We should be good to merge.

@datumbox datumbox merged commit 1db8795 into pytorch:main Mar 28, 2022
@datumbox datumbox deleted the generalized_box_iou_asserts branch March 28, 2022 14:05
facebook-github-bot pushed a commit that referenced this pull request Apr 5, 2022
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: YosuaMichael

Differential Revision: D35216795

fbshipit-source-id: e980727b4799e31bd4729aadf107f5d98307f6e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants