Moving sequence_to_str to torchvision._utils
#5604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 13e5eb6 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
reviewed
Mar 14, 2022
datumbox
force-pushed
the
utils/sequence_to_str
branch
from
4ba169f to
4ccc7f1
Compare
pmeier
approved these changes
Mar 14, 2022
|
The failing test is unrelated. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
Summary: * Moving `sequence_to_str` to `torchvision._utils` * Fix linter * Rename test_prototype_utils test to test_internal_utils Reviewed By: vmoens Differential Revision: D34878983 fbshipit-source-id: 02a5425a9d25056035d28307cf307e0c5353c94f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #4679
The method
sequence_to_stris used both by prototype models and datasets. The work on #5603 requires moving it on thetorchvision._utilsprivate package but during this move we modifyprototype.datasets. As this will almost certainly lead to conflicts, I'm bringing this move on a separate PR. The method is added on a private package so future changes can be made without BC worries.