Skip to content

add option to fail a transform on certain types rather than passthrough #5432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 16, 2022

Addresses 1. from #5418 (comment).

@facebook-github-bot
Copy link

facebook-github-bot commented Feb 16, 2022

💊 CI failures summary and remediations

As of commit 93c6cd5 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit e13206d into pytorch:main Feb 16, 2022
@pmeier pmeier deleted the transforms-fail-types branch February 16, 2022 20:10
facebook-github-bot pushed a commit that referenced this pull request Feb 25, 2022
…passthrough (#5432)

Summary:
* add option to fail a transform on certain types rather than passthrough

* address comments

Reviewed By: jdsgomes

Differential Revision: D34475317

fbshipit-source-id: 0b66536b5de473d339810e534ad644a14a5b4f45

Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants