Skip to content

Fix URL to Flickr30kEntities webpage #5372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

eyurtsev
Copy link
Contributor

@eyurtsev eyurtsev commented Feb 3, 2022

This PR updates the URL referenced in the documentation Flickr30k dataset. The old URL seems to result in a 404.

@facebook-github-bot
Copy link

Hi @eyurtsev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

facebook-github-bot commented Feb 3, 2022

💊 CI failures summary and remediations

As of commit e863ed0 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build binary_win_wheel_py3.9_cu115 (1/1)

Step: "Build wheel packages" (full log | diagnosis details | 🔁 rerun)

if errorlevel 1 exit /b 1
 set "CUDNN_SETUP_FILE=C:\Users\circleci\project\packaging\windows\internal\\..\temp_build\cudnn-11.3-windows-x64-v8.2.0.53.zip" 
) 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  2  737M    2 16.0M    0     0  16.0M      0  0:00:46  0:00:01  0:00:45 14.4M
  9  737M    9 72.0M    0     0  36.0M      0  0:00:20  0:00:02  0:00:18 33.6M
 14  737M   14  106M    0     0  35.3M      0  0:00:20  0:00:03  0:00:17 33.8M
 19  737M   19  142M    0     0  35.5M      0  0:00:20  0:00:04  0:00:16 34.3M
 23  737M   23  176M    0     0  35.2M      0  0:00:20  0:00:05  0:00:15 35.9M
 28  737M   28  206M    0     0  34.4M      0  0:00:21  0:00:06  0:00:15 38.1M
 34  737M   34  254M    0     0  36.3M      0  0:00:20  0:00:07  0:00:13 36.7M
 39  737M   39  289M    0     0  36.1M      0  0:00:20  0:00:08  0:00:12 37.0M
 44  737M   44  328M    0     0  36.4M      0  0:00:20  0:00:09  0:00:11 37.1M
 50  737M   50  370M    0     0  37.0M      0  0:00:19  0:00:10  0:00:09 38.6M
 54  737M   54  404M    0     0  36.7M      0  0:00:20  0:00:11  0:00:09 39.5M
 59  737M   59  439M    0     0  36.6M      0  0:00:20  0:00:12  0:00:08 36.8M
 63  737M   63  468M    0     0  36.0M      0  0:00:20  0:00:13  0:00:07 35.7M
 66  737M   66  488M    0     0  34.8M      0  0:00:21  0:00:14  0:00:07 32.2M
 69  737M   69  512M    0     0  34.1M      0  0:00:21  0:00:15  0:00:06 28.5M
 75  737M   75  560M    0     0  35.0M      0  0:00:21  0:00:16  0:00:05 30.6M
 82  737M   82  605M    0     0  35.6M      0  0:00:20  0:00:17  0:00:03 33.4M
 86  737M   86  638M    0     0  35.4M      0  0:00:20  0:00:18  0:00:02 33.7M
 90  737M   90  670M    0     0  35.3M      0  0:00:20  0:00:19  0:00:01 36.6M
 96  737M   96  710M    0     0  35.5M      0  0:00:20  0:00:20 --:--:-- 39.7M
100  737M  100  737M    0     0  36.8M      0  0:00:20  0:00:20 --:--:-- 38.0M

C:\Users\circleci\project>goto cuda_common 

C:\Users\circleci\project>if not exist "C:\Users\circleci\project\packaging\windows\internal\\..\temp_build\NvToolsExt.7z" (
curl -k -L https://www.dropbox.com/s/9mcolalfdj4n979/NvToolsExt.7z?dl=1 --output "C:\Users\circleci\project\packaging\windows\internal\\..\temp_build\NvToolsExt.7z"  
 if errorlevel 1 exit /b 1 
) 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   137    0   137    0     0    137      0 --:--:-- --:--:-- --:--:--   796

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   320  100   320    0     0    320      0  0:00:01 --:--:--  0:00:01  2051

100  108k    0  108k    0     0   108k      0 --:--:-- --:--:-- --:--:--  108k

C:\Users\circleci\project>echo Installing CUDA toolkit... 
Installing CUDA toolkit...


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eyurtsev !

@NicolasHug NicolasHug merged commit 22f8dc4 into pytorch:main Feb 4, 2022
facebook-github-bot pushed a commit that referenced this pull request Feb 11, 2022
Summary: Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: NicolasHug

Differential Revision: D34140250

fbshipit-source-id: 371a9081bfc0cd12c8492266497a7ab416697cba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants