Skip to content

Adding vit_h_14 architecture #5210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 19, 2022
Merged

Adding vit_h_14 architecture #5210

merged 6 commits into from
Jan 19, 2022

Conversation

yiwen-song
Copy link
Contributor

@yiwen-song yiwen-song commented Jan 19, 2022 •
edited by pytorch-probot bot
Loading

See whether the unittest can pass after changes in #5176

cc @datumbox

@facebook-github-bot
Copy link

facebook-github-bot commented Jan 19, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit b322765 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@yiwen-song yiwen-song marked this pull request as draft January 19, 2022 02:56
@yiwen-song yiwen-song added enhancement module: models.quantization Issues related to the quantizable/quantized models module: models and removed module: models.quantization Issues related to the quantizable/quantized models labels Jan 19, 2022
@yiwen-song yiwen-song marked this pull request as ready for review January 19, 2022 03:47
kazhang
kazhang approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@kazhang kazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sallysyw !

@yiwen-song yiwen-song merged commit 03d1133 into pytorch:main Jan 19, 2022
@yiwen-song yiwen-song deleted the vit_h_14 branch January 19, 2022 19:35
@datumbox datumbox mentioned this pull request Jan 21, 2022
Closed
@datumbox datumbox added the revert(ed) For reverted PRs, and PRs that revert other PRs label Jan 23, 2022
@datumbox
Copy link
Contributor

This PR breaks our CI and causes memory issue not only for ViT but also for other models. Given that we don't offer weights for it, we should revert and investigate ways to add it back without breaking the CI.

@datumbox datumbox mentioned this pull request Jan 23, 2022
Merged
facebook-github-bot pushed a commit that referenced this pull request Jan 26, 2022
@datumbox @facebook-github-bot
[fbsync] Adding vit_h_14 architecture (#5210)
a207936 
Summary:
* adding vit_h_14

* prototype and docs

* bug fix

* adding curl check

Reviewed By: jdsgomes, prabhat00155

Differential Revision: D33739390

fbshipit-source-id: 22a2c6a5c5b8b2a62d78333662c60604f65d883b
@datumbox datumbox mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazhang kazhang kazhang approved these changes

@datumbox datumbox Awaiting requested review from datumbox

Assignees
No one assigned
Labels
ciflow/default cla signed enhancement module: models revert(ed) For reverted PRs, and PRs that revert other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiwen-song @facebook-github-bot @datumbox @kazhang