Skip to content

Log io usage #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 21, 2021
Merged

Log io usage #5038

merged 15 commits into from
Dec 21, 2021

Conversation

kazhang
Copy link
Contributor

@kazhang kazhang commented Dec 7, 2021

Log IO api usages.
Partially-close: #4955
Partially-close: #5052

@facebook-github-bot
Copy link

facebook-github-bot commented Dec 7, 2021

💊 CI failures summary and remediations

As of commit 62f4507 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

datumbox
datumbox previously approved these changes Dec 7, 2021
@kazhang
Copy link
Contributor Author

kazhang commented Dec 8, 2021

I opened an issue(#5052) to get consensus around logging policy and event format.
cc @datumbox @fmassa @NicolasHug @prabhat00155

@kazhang kazhang marked this pull request as draft December 9, 2021 23:20
@kazhang kazhang marked this pull request as ready for review December 9, 2021 23:25
@datumbox datumbox dismissed their stale review December 17, 2021 09:34

Changed API

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kazhang kazhang merged commit da7680f into pytorch:main Dec 21, 2021
@github-actions
Copy link

Hey @kazhang!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Dec 21, 2021
Summary:
* add api usage log for io

* cover VideoReader

* cover c++ APIs

* add api usage log for io

* cover VideoReader

* cover c++ APIs

* add _cpp suffix to c++ APIs

* use new API and change cpp format

* remove _cpp suffix

* adopt new API

* lint

Reviewed By: prabhat00155

Differential Revision: D33253468

fbshipit-source-id: deef97d8cc430406e352e88761e2bc680e7c38da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API usage logging within TorchVision Add _log_api_usage_once() calls on remaining endpoints
6 participants