Skip to content

Add typing in detection module (faster rcnn). #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

khushi-411
Copy link
Contributor

Follows #4582.

@oke-aditya
Copy link
Contributor

Hi @khushi-411.

Nice to see the PR,

Faster-rcnn file depends on other files currently in the chain.
Since we inherit from generalized rcnn, and also need transforms to be typed. It is good to wait a while.
I suggest to not close this PR, but instead just wait as we work up the chain 😃 Surely we will make use of these types soon!

@khushi-411 khushi-411 marked this pull request as draft October 18, 2021 06:48
@khushi-411
Copy link
Contributor Author

khushi-411 commented Oct 18, 2021

Hi @oke-aditya,
Thanks, it was a pleasant start after a week's holiday.

BTW, Thanks for the info!

@datumbox
Copy link
Contributor

FYI there is a parallel effort of refactoring models inside the prototype folder. See:
https://github.com/pytorch/vision/blob/main/torchvision/prototype/models/detection/faster_rcnn.py

I believe this one is typed but worth checking. :)

@oke-aditya
Copy link
Contributor

Eventhough the CI looks green, let's not hurry 😃 Since inherited classes can often mismatch later.

@khushi-411 khushi-411 closed this Nov 19, 2022
@khushi-411 khushi-411 deleted the type_faster_rcnn branch November 19, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants